Skip to content

[python][scikit-learn] change MRO #3192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jameslamb merged 11 commits into from
Apr 26, 2021
Merged

[python][scikit-learn] change MRO #3192

Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
fede3a2
chanche MRO
StrikerRUS Jun 27, 2020
0f2f43d
Merge branch 'master' into sklearn
StrikerRUS Jun 27, 2020
204f8ef
Merge branch 'master' into sklearn
StrikerRUS Jul 31, 2020
f796fda
Merge branch 'master' into sklearn
StrikerRUS Aug 10, 2020
39880c9
Merge branch 'master' into sklearn
StrikerRUS Sep 6, 2020
ce9f370
Merge branch 'master' into sklearn
StrikerRUS Nov 15, 2020
6722bbe
Merge branch 'master' into sklearn
StrikerRUS Jan 3, 2021
6c9da81
Merge branch 'master' into sklearn
StrikerRUS Feb 1, 2021
2097ec8
Merge branch 'master' into sklearn
StrikerRUS Mar 26, 2021
6831840
fix MRO resolution
StrikerRUS Apr 23, 2021
9385cf6
Merge branch 'master' into sklearn
StrikerRUS Apr 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions python-package/lightgbm/sklearn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -731,7 +731,7 @@ def feature_name_(self):
return self._Booster.feature_name()


class LGBMRegressor(LGBMModel, _LGBMRegressorBase):
class LGBMRegressor(_LGBMRegressorBase, LGBMModel):
"""LightGBM regressor."""

def fit(self, X, y,
Expand All @@ -758,7 +758,7 @@ def fit(self, X, y,
+ _base_doc[_base_doc.find('eval_init_score :'):])


class LGBMClassifier(LGBMModel, _LGBMClassifierBase):
class LGBMClassifier(_LGBMClassifierBase, LGBMModel):
"""LightGBM classifier."""

def fit(self, X, y,
Expand Down