Implement support for groupshared arg attribute #8013
+366
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get compiler to error when types aren't exactly the same + arg not groupshared bug fix fix test disallow groupshared param in export/noinline funcs first check if there are attrs remove accidental change tests
update tests to show new mangling
Contributor
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
hekota
reviewed
Jan 9, 2026
Member
hekota
left a comment
There was a problem hiding this comment.
Mostly looks good, I just have a few comments and suggestions/nits.
tools/clang/test/SemaHLSL/v202x/groupshared/NotGroupSharedTest.hlsl
Outdated
Show resolved
Hide resolved
tools/clang/test/SemaHLSL/v202x/groupshared/NotGroupSharedTest.hlsl
Outdated
Show resolved
Hide resolved
Member
|
Please add something to https://github.com/microsoft/DirectXShaderCompiler/blob/main/docs/ReleaseNotes.md as appropriate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements support for groupshared argument attribute.
Closes #7969