Skip to content

[WEB-5911] fix: error outline button text color #8531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aaryan610 wants to merge 1 commit into
base: preview
Choose a base branch
from
+11 −11
Open

[WEB-5911] fix: error outline button text color #8531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/propel/src/button/helper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ export const buttonVariants = cva(
"error-fill":
"bg-danger-primary hover:bg-danger-primary-hover active:bg-danger-primary-active disabled:bg-layer-disabled text-on-color disabled:text-disabled",
"error-outline":
"bg-layer-2 hover:bg-danger-subtle active:bg-danger-subtle-hover disabled:bg-layer-2 text-danger-primary disabled:text-disabled border border-danger-strong disabled:border-subtle-1",
"bg-layer-2 hover:bg-danger-subtle active:bg-danger-subtle-hover disabled:bg-layer-2 text-danger-secondary disabled:text-disabled border border-danger-strong disabled:border-subtle-1",
secondary:
"bg-layer-2 hover:bg-layer-2-hover active:bg-layer-2-active disabled:bg-layer-transparent text-secondary disabled:text-disabled border border-strong disabled:border-subtle-1 shadow-raised-100",
"bg-layer-2 hover:bg-layer-2-hover active:bg-layer-2-active disabled:bg-layer-transparent text-secondary disabled:text-disabled border border-strong disabled:border-subtle-1 shadow-raised-100",
tertiary:
"bg-layer-3 hover:bg-layer-3-hover active:bg-layer-3-active disabled:bg-layer-transparent text-secondary disabled:text-disabled",
ghost:
Expand Down
18 changes: 9 additions & 9 deletions packages/tailwind-config/variables.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,7 +506,7 @@
--border-success-subtle: var(--green-200);
--border-warning-strong: var(--amber-400);
--border-warning-subtle: var(--amber-200);
--border-danger-strong: var(--red-400);
--border-danger-strong: var(--red-700);
--border-danger-subtle: var(--red-200);
/* Text colors */
--txt-primary: var(--neutral-1200);
Expand Down Expand Up @@ -1059,42 +1059,42 @@
--text-h4-bold--letter-spacing: var(--tracking-default);
--text-h4-bold--font-weight: var(--font-weight-bold);

--text-h5-regular: var(--text-16);
--text-h5-regular: var(--text-18);
--text-h5-regular--line-height: 1.2;
--text-h5-regular--letter-spacing: var(--tracking-default);
--text-h5-regular--font-weight: var(--font-weight-regular);

--text-h5-medium: var(--text-16);
--text-h5-medium: var(--text-18);
--text-h5-medium--line-height: 1.2;
--text-h5-medium--letter-spacing: var(--tracking-default);
--text-h5-medium--font-weight: var(--font-weight-medium);

--text-h5-semibold: var(--text-16);
--text-h5-semibold: var(--text-18);
--text-h5-semibold--line-height: 1.2;
--text-h5-semibold--letter-spacing: var(--tracking-default);
--text-h5-semibold--font-weight: var(--font-weight-semibold);

--text-h5-bold: var(--text-16);
--text-h5-bold: var(--text-18);
--text-h5-bold--line-height: 1.2;
--text-h5-bold--letter-spacing: var(--tracking-default);
--text-h5-bold--font-weight: var(--font-weight-bold);

--text-h6-regular: var(--text-14);
--text-h6-regular: var(--text-16);
--text-h6-regular--line-height: 1.2;
--text-h6-regular--letter-spacing: var(--tracking-default);
--text-h6-regular--font-weight: var(--font-weight-regular);

--text-h6-medium: var(--text-14);
--text-h6-medium: var(--text-16);
--text-h6-medium--line-height: 1.2;
--text-h6-medium--letter-spacing: var(--tracking-default);
--text-h6-medium--font-weight: var(--font-weight-medium);

--text-h6-semibold: var(--text-14);
--text-h6-semibold: var(--text-16);
--text-h6-semibold--line-height: 1.2;
--text-h6-semibold--letter-spacing: var(--tracking-default);
--text-h6-semibold--font-weight: var(--font-weight-semibold);

--text-h6-bold: var(--text-14);
--text-h6-bold: var(--text-16);
Comment on lines +1062 to +1097
Copy link

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The typography size changes for h5 (from text-16 to text-18) and h6 (from text-14 to text-16) heading variants are not mentioned in the PR description. The PR description only mentions updating text color for error outline button and border danger primary value for dark mode. These typography changes represent a significant design system update that could affect many components across the application and should be explicitly documented in the PR description.

Copilot uses AI. Check for mistakes.
--text-h6-bold--line-height: 1.2;
--text-h6-bold--letter-spacing: var(--tracking-default);
--text-h6-bold--font-weight: var(--font-weight-bold);
Expand Down
Loading