Skip to content

[SILO-820] fix: update serializer for module detail API endpoint to use ModuleUpdateSerializer #8496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dheeru0198 wants to merge 1 commit into
base: preview
Choose a base branch
from
+1 −1
Open

[SILO-820] fix: update serializer for module detail API endpoint to use ModuleUpdateSerializer #8496

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/api/plane/api/views/module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ def patch(self, request, slug, project_id, pk):
{"error": "Archived module cannot be edited"},
status=status.HTTP_400_BAD_REQUEST,
)
serializer = ModuleSerializer(module, data=request.data, context={"project_id": project_id}, partial=True)
serializer = ModuleUpdateSerializer(module, data=request.data, context={"project_id": project_id}, partial=True)
Copy link

@cursor cursor bot Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update endpoint returns incomplete response data

Medium Severity

The patch method now returns ModuleUpdateSerializer.data directly, but this serializer only includes a limited subset of fields (name, description, dates, status, lead, members, external_source, external_id). The response is missing important fields like id, total_issues, completed_issues, and other computed metrics. The create method follows the correct pattern by re-fetching the module and using ModuleSerializer for the response. The OpenAPI documentation also specifies ModuleSerializer as the response type, creating an inconsistency. API consumers expecting the full module data in the update response will receive incomplete data.

Additional Locations (1)

Fix in Cursor Fix in Web

if serializer.is_valid():
if (
request.data.get("external_id")
Expand Down
Loading