Plane-EE: Configurable busybox image

[hajowieland]

Description

The busybox image used by MinIO and Silo is hardcoded in the Helm templates and not configurable. This is problematic, as users might want to pin the version, use a custom image, or need to pull from their own registry.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• Feature (non-breaking change which adds functionality)
• Improvement (change that would cause existing functionality to not work as expected)
• Code refactoring
• Performance improvements
• Documentation update

Summary by CodeRabbit

• Chores
  • Updated Helm chart configurations to use templated busybox image references for MinIO and Silo workloads, enabling customizable image values through configuration settings.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Warning

Rate limit exceeded

@hajowieland has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 17 minutes and 59 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 19b0c2a and 6bca788.

📒 Files selected for processing (2)

• charts/plane-enterprise/templates/workloads/silo.deployment.yaml (2 hunks)
• charts/plane-enterprise/values.yaml (2 hunks)

Walkthrough

Helm templates for MinIO and Silo workloads are updated to use configurable busybox images via templated values instead of hardcoded references. New configuration fields added to the values file. Minor formatting adjustments applied across templates.

Changes

Cohort / File(s)	Summary
Workload template updates charts/plane-enterprise/templates/workloads/minio.stateful.yaml, charts/plane-enterprise/templates/workloads/silo.deployment.yaml	Replaced hardcoded busybox init container images with template-provided values ({{ .Values.services.minio.image_busybox }} and {{ .Values.services.silo.busyboxImage }}). Minor formatting adjustments to console-address args and end-of-block template syntax.
Helm values configuration charts/plane-enterprise/values.yaml	Added image_busybox: busybox to minio service and busyboxImage: busybox to silo service configuration sections.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

• Changes follow a consistent pattern: hardcoded image references replaced with templated values
• Mostly mechanical substitutions with minor formatting harmonization
• Additive configuration entries with no logic alterations
• Low risk of unintended side effects

Poem

🐰 Busybox now dances with variables free,
No more locked in stone—configurable as can be!
Templates sing, values aligned with care,
Flexibility blooms in the Helm-chart air! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately and concisely describes the main change: making the BusyBox image configurable in the Plane Enterprise Helm charts.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

charts/plane-enterprise/values.yaml (1)

87-87: Pin specific BusyBox image versions instead of using untagged busybox.

Both defaults (busybox without tag) will pull the latest image, violating reproducibility and introducing unnecessary variability. Other services in this file pin specific versions (e.g., valkey:7.2.11-alpine, postgres:15.7-alpine). Pin BusyBox to a stable version such as busybox:1.37.0-alpine to match the immutability principle across the chart.

  minio:
    local_setup: true
    image: minio/minio:latest
    image_mc: minio/mc:latest
-   image_busybox: busybox
+   image_busybox: busybox:1.37.0-alpine
    volumeSize: 3Gi

  silo:
    enabled: true
    replicas: 1
    memoryLimit: 1000Mi
    cpuLimit: 500m
    memoryRequest: 50Mi
    cpuRequest: 50m
    image: artifacts.plane.so/makeplane/silo-commercial
-   busyboxImage: busybox
+   image_busybox: busybox:1.37.0-alpine
    pullPolicy: Always

Also applies to: 239-239

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9329805 and 19b0c2a.

📒 Files selected for processing (3)

• charts/plane-enterprise/templates/workloads/minio.stateful.yaml (4 hunks)
• charts/plane-enterprise/templates/workloads/silo.deployment.yaml (2 hunks)
• charts/plane-enterprise/values.yaml (2 hunks)

🔇 Additional comments (4)

charts/plane-enterprise/templates/workloads/silo.deployment.yaml (2)

46-46: Verify template reference matches finalized values.yaml key name.

This line references .Values.services.silo.busyboxImage, but due to the naming inconsistency noted in values.yaml, this reference may need to change to .Values.services.silo.image_busybox if the field is standardized to snake_case.

Confirm that the template reference aligns with the corrected values.yaml field naming convention.

---

52-61: Unexpected logic change beyond scope: conditional RabbitMQ wait behavior.

The AI summary describes "minor formatting adjustments," but lines 52–61 introduce significant behavioral changes: a conditional check that skips the RabbitMQ wait if an external RabbitMQ URL is detected. This goes beyond configuring the BusyBox image and represents a distinct feature addition.

Clarify whether this logic change is intentional (and if so, verify it's correct) or should be separated into a distinct PR.

1. Is the conditional RabbitMQ detection intentional or scope creep?
2. Should minio's init container (in the other template) have similar logic?
3. Does this behavior align with the project's goals for this PR?

Provide context on why this change was bundled with the busybox configurability fix.

charts/plane-enterprise/templates/workloads/minio.stateful.yaml (2)

100-100: ✓ BusyBox image templating is correct.

The reference to .Values.services.minio.image_busybox is consistent with values.yaml and replaces the hardcoded image as intended. However, verify that this field name aligns with the standardization correction suggested in the values.yaml review (if minio field is renamed, ensure this reference follows).

---

111-113: Command formatting is acceptable.

The reformatting of the mc configuration and bucket creation commands (separating them onto distinct lines with proper semicolon handling) improves readability without changing behavior. The command semantics are preserved.