[INFRA-178] Plane-CE: Add resource requests for Plane CE Helm Chart #116
Conversation
- Updated `questions.yml` to include memory and CPU request variables for web, space, admin, live, api, worker, and beatworker components. - Modified `values.yaml` to set default memory and CPU requests for each component. - Adjusted deployment templates to utilize the new request configurations for memory and CPU.
WalkthroughThis update introduces configurable resource request parameters for CPU and memory across multiple components in the Helm chart. It modifies deployment templates to use these new values, updates the values and questions configuration files, and increments the chart version. No changes were made to logic or exported entities. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Helm Chart
participant Kubernetes
User->>Helm Chart: Provide values for cpuRequest/memoryRequest (optional)
Helm Chart->>Kubernetes: Render deployment manifests with resource requests
Kubernetes->>Kubernetes: Deploy containers with specified resource requests
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
charts/plane-ce/questions.yml (1)
297-304: New resource request options for the beatworker component & trailing space cleanup.
Addedbeatworker.memoryRequestandbeatworker.cpuRequestwith defaults (50Mi/50m). There's a trailing space on line 304; please remove it to satisfy YAML linting.
Proposed cleanup:- - variable: beatworker.cpuRequest - type: string - default: 50m + - variable: beatworker.cpuRequest + type: string + default: 50m🧰 Tools
🪛 YAMLlint (1.37.1)
[error] 304-304: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (10)
charts/plane-ce/Chart.yaml(1 hunks)charts/plane-ce/questions.yml(7 hunks)charts/plane-ce/templates/workloads/admin.deployment.yaml(1 hunks)charts/plane-ce/templates/workloads/api.deployment.yaml(1 hunks)charts/plane-ce/templates/workloads/beat-worker.deployment.yaml(1 hunks)charts/plane-ce/templates/workloads/live.deployment.yaml(1 hunks)charts/plane-ce/templates/workloads/space.deployment.yaml(1 hunks)charts/plane-ce/templates/workloads/web.deployment.yaml(1 hunks)charts/plane-ce/templates/workloads/worker.deployment.yaml(1 hunks)charts/plane-ce/values.yaml(6 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
charts/plane-ce/questions.yml
[error] 304-304: trailing spaces
(trailing-spaces)
🔇 Additional comments (21)
charts/plane-ce/Chart.yaml (1)
8-8: Bump chart version to 1.1.2
Version has been incremented to reflect the addition of configurable resource requests across the chart.charts/plane-ce/templates/workloads/beat-worker.deployment.yaml (1)
27-28: Parameterize beat-worker resource requests
Replaces hard-coded"50Mi"and"50m"with.Values.beatworker.memoryRequestand.Values.beatworker.cpuRequest, falling back to the original defaults.charts/plane-ce/templates/workloads/api.deployment.yaml (1)
49-50: Expose API container resource requests via values
Switches fixed memory and CPU requests to.Values.api.memoryRequestand.Values.api.cpuRequestwith default fallbacks, aligning with other components.charts/plane-ce/templates/workloads/worker.deployment.yaml (1)
27-28: Parameterize worker resource requests
Introduces.Values.worker.memoryRequestand.Values.worker.cpuRequestin place of static"50Mi"and"50m", preserving existing defaults.charts/plane-ce/values.yaml (7)
76-77: Add default resource requests for web component
DefinescpuRequest: 50mandmemoryRequest: 50Mito match the templated requests inweb.deployment.yaml.
86-87: Add default resource requests for space component
IntroducescpuRequest: 50mandmemoryRequest: 50Mifor the space service.
96-97: Add default resource requests for admin component
DefinescpuRequest: 50mandmemoryRequest: 50Mito enable configurable admin workloads.
106-107: Add default resource requests for live component
AddscpuRequest: 50mandmemoryRequest: 50Midefaults for live workloads.
116-117: Add default resource requests for api component
ConfigurescpuRequest: 50mandmemoryRequest: 50Mito back the API deployment changes.
126-127: Add default resource requests for worker component
DefinescpuRequest: 50mandmemoryRequest: 50Mito match the templated worker resource requests.
135-136: Add default resource requests for beatworker component
IntroducescpuRequest: 50mandmemoryRequest: 50Midefaults for the beat-worker.charts/plane-ce/templates/workloads/admin.deployment.yaml (1)
49-50: Dynamic resource requests templating applied correctly.
Resource requests for the admin container now reference.Values.admin.memoryRequestand.Values.admin.cpuRequestwith sensible defaults (50Mi/50m) and proper quoting.charts/plane-ce/templates/workloads/space.deployment.yaml (1)
49-50: Dynamic resource requests templating applied correctly.
Resource requests for the space container now reference.Values.space.memoryRequestand.Values.space.cpuRequestwith defaults and quoting, enabling configurability while preserving defaults.charts/plane-ce/templates/workloads/web.deployment.yaml (1)
49-50: Dynamic resource requests templating applied correctly.
Resource requests for the web container now reference.Values.web.memoryRequestand.Values.web.cpuRequestwith defaults and quoting, improving configurability.charts/plane-ce/templates/workloads/live.deployment.yaml (1)
49-50: Dynamic resource requests templating applied correctly.
Resource requests for the live container now reference.Values.live.memoryRequestand.Values.live.cpuRequestwith fallbacks (50Mi/50m) and are quoted to ensure valid YAML.charts/plane-ce/questions.yml (6)
58-65: New resource request options for the web component.
Addedweb.memoryRequestandweb.cpuRequestsubquestions with defaults (50Mi/50m), aligning with the templated values in the web deployment.
94-101: New resource request options for the space component.
Addedspace.memoryRequestandspace.cpuRequestsubquestions with defaults (50Mi/50m), matching the templated space deployment.
138-145: New resource request options for the admin component.
Addedadmin.memoryRequestandadmin.cpuRequestsubquestions with defaults (50Mi/50m), consistent with the admin deployment changes.
178-185: New resource request options for the live component.
Introducedlive.memoryRequestandlive.cpuRequestwith defaults (50Mi/50m) to support live deployment templating.
231-238: New resource request options for the API component.
Addedapi.memoryRequestandapi.cpuRequestentries with defaults (50Mi/50m), aligning with API deployment templates.
275-282: New resource request options for the worker component.
Includedworker.memoryRequestandworker.cpuRequestsubquestions with defaults (50Mi/50m), enabling the worker resource configuration.
|
Pull Request Linked with Plane Work Items
Comment Automatically Generated by Plane |
- Included `memoryRequest` and `cpuRequest` parameters for web, space, admin, live, api, worker, and beatworker components in the documentation. - Updated descriptions to clarify the purpose of these new parameters in the context of Kubernetes deployments.
- Updated memory and CPU limit configurations in `space.deployment.yaml` to reference the correct `space` values instead of `web` values, ensuring accurate resource allocation for the space component.
- Changed the image reference in `space.deployment.yaml` to use `space.image` instead of `space.images`, ensuring consistency with the updated configuration structure.
Description
Added configurable CPU and memory resource request options for all major service components, allowing users to customize resource allocation for web, space, admin, live, api, worker, and beatworker components through the Helm chart interface
Type of Change
Summary by CodeRabbit
New Features
Documentation
Chores