📝 add documentation to CMake find-package support #806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
COM8
requested changes
Aug 14, 2022
Member
COM8
left a comment
There was a problem hiding this comment.
Thanks for your PR! Only one minor thing and we are ready to do.
README.md
Outdated
Comment on lines
107
to
108
| $ make -j | ||
| $ sudo make install |
Member
There was a problem hiding this comment.
I prefer the CMake way of doing this, which is platform independent:
Suggested change
| $ make -j | |
| $ sudo make install | |
| $ cmake --build . | |
| $ sudo cmake --build . --target install |
Co-authored-by: Fabian Sauter <[email protected]>
CMake version >= 3.15
Contributor
Author
|
@COM8, since CMake version >= 3.15 we can do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds documentation in README.md to CMake find-package support (#645)