Skip to content

[10.x] Make the firstOrCreate methods in relations use createOrFirst behind the scenes #48192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
taylorotwell merged 6 commits into from
Aug 27, 2023
Merged

[10.x] Make the firstOrCreate methods in relations use createOrFirst behind the scenes #48192

taylorotwell merged 6 commits into from
Aug 27, 2023

Conversation

@tonysm
Copy link
Contributor

@tonysm tonysm commented Aug 26, 2023 •
edited
Loading

Changed

  • In [10.x] Adds a createOrFirst method to Eloquent #47973, I only switched the Builder::firstOrCreate to also use the createOrFirst behind to scenes and missed the BelongsToMany::firstOrCreate and HasOneOrMany::firstOrCreate. This PR also changes the missed methods to use firstOrCreate instead of simply trying to create related records after not finding them, also solving the race condition issue in the relations.
  • Wraps the "attach" method call on the BelongsToMany::firstOrCreate in a SAVEPOINT if needed and a try/catch to handle the unique violation there as well, making it more robust

Hat tip to @mpyw for pointing out that I missed those methods in the original implementation.

tonysm added 2 commits August 26, 2023 00:34
@tonysm
Use createOrFirst inside firstOrCreate in BelongsToMany relations
61c7b91 
This should be the same but more robust, since it handles race conditions as well
@tonysm
Use createOrFirst too inside HasOneOrMany relations
a2c0f8e 
This should essentially be the same as before, but more robust
@tonysm tonysm changed the title [10.x] Use createOrFirst in relations [10.x] Make the firstOrCreate methods in relations use createOrFirst behind the scenes Aug 26, 2023
@mpyw mpyw mentioned this pull request Aug 26, 2023
Merged
@tonysm tonysm marked this pull request as draft August 26, 2023 19:08
@tonysm tonysm marked this pull request as ready for review August 26, 2023 19:26
@taylorotwell taylorotwell merged commit 24cbb80 into laravel:10.x Aug 27, 2023
@mpyw mpyw mentioned this pull request Aug 28, 2023
Merged
taylorotwell pushed a commit that referenced this pull request Aug 29, 2023
@mpyw
[10.x] Make the updateOrCreate methods in relations use `firstOrCre…
e1ae507 
…ate` behind the scenes (#48213)

* Make the `updateOrCreate` methods in relations use `firstOrCreate`

Related to #48160, #48192

* Fix tests

* Fix: correctly apply unused `$joining` and `$touch`

* Fix: `save()` should always accepts `['touch' => false]`
@mpyw mpyw mentioned this pull request Aug 30, 2023
Merged
@edcheyjr edcheyjr mentioned this pull request Sep 4, 2023
Merged
@ralphjsmit ralphjsmit mentioned this pull request Sep 25, 2023
Closed
@tonysm tonysm mentioned this pull request Sep 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tonysm @taylorotwell