Handle client sending new NodeKey #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
cure
approved these changes
Jun 6, 2021
Contributor
cure
left a comment
There was a problem hiding this comment.
Just one small nit, looks good otherwise, thanks!
|
|
||
| resp.MachineAuthorized = true | ||
| resp.User = *pak.Namespace.toUser() | ||
| pak, err := h.checkKeyValidity(req.Auth.AuthKey) |
Contributor
There was a problem hiding this comment.
Can we add a check before this line that req.Auth is not nil? Otherwise, if it ever were nil, we'd get a runtime panic.
Owner
Author
There was a problem hiding this comment.
But req.Auth cannot be nil https://github.com/tailscale/tailscale/blob/main/tailcfg/tailcfg.go#L602
Contributor
There was a problem hiding this comment.
OK that's fair, never mind then thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes a bit how we handle the registration workflow. Hopefully solves #32.