make tags first class node owner #2885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fe1266c to
2a8ca3e
Compare
45bdb84 to
6d9d63d
Compare
c089a04 to
ef7b0a9
Compare
This commit changes tags to be something that exists on nodes in addition to users, to being its own thing. It is part of moving our tags support towards the correct tailscale compatible implementation. There are probably rough edges in this commit, but the intention is to get it in, and then start fixing bugs from 0.28.0 milestone (long standing tags issue) to discover what works and what doesnt. Updates juanfont#2417 Closes juanfont#2619
Signed-off-by: Kristoffer Dalby <[email protected]>
Signed-off-by: Kristoffer Dalby <[email protected]>
ef7b0a9 to
467036f
Compare
juanfont
approved these changes
Dec 2, 2025
Signed-off-by: Kristoffer Dalby <[email protected]>
This was referenced Dec 11, 2025
kradalby
added a commit
to kradalby/headscale
that referenced
this pull request
Dec 11, 2025
Update TestTaildrop to validate that juanfont#2462 is fixed through juanfont#2885 and juanfont#2931. Fixes juanfont#2462 Signed-off-by: Kristoffer Dalby <[email protected]>
kradalby
added a commit
to kradalby/headscale
that referenced
this pull request
Dec 11, 2025
Update TestTaildrop to validate that juanfont#2462 is fixed through juanfont#2885 and juanfont#2931. Fixes juanfont#2462 Signed-off-by: Kristoffer Dalby <[email protected]>
kradalby
added a commit
to kradalby/headscale
that referenced
this pull request
Dec 11, 2025
Update TestTaildrop to validate that juanfont#2462 is fixed through juanfont#2885 and juanfont#2931. Fixes juanfont#2462 Signed-off-by: Kristoffer Dalby <[email protected]>
This was referenced Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes tags to be something that exists on nodes in addition to users, to being its own thing. It is part of moving our tags support towards the correct tailscale compatible implementation.
There are probably rough edges in this PR, but the intention is to get it in, and then start fixing bugs from 0.28.0 milestone (long standing tags issue) to discover what works and what doesnt.
Updates #2417
Closes #2619