cli: only validate bypass-grpc set policy #2854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nblock
reviewed
Nov 2, 2025
cmd/headscale/cli/policy.go
Outdated
|
|
||
| users, err := d.ListUsers() | ||
| if err != nil { | ||
| ErrorOutput(err, fmt.Sprintf("Failed to load users fro policy validation: %s", err), output) |
nblock
approved these changes
Nov 2, 2025
Collaborator
nblock
left a comment
There was a problem hiding this comment.
Works with the sample from: #2825 (comment)
When adding the mode to bypass gRPC, a naive policy validation was added to both the gRPC set, and the bypass mode. This caused the policy to invalidate in unexpected ways as the gRPC already handles this validation in the backend. This commit moves the validation logic into the bypass branch. Fixes juanfont#2825 Signed-off-by: Kristoffer Dalby <[email protected]>
981cd92 to
c54e917
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding the mode to bypass gRPC, a naive policy validation was added to both the gRPC set, and the bypass mode.
This caused the policy to invalidate in unexpected ways as the gRPC already handles this validation in the backend.
This commit moves the validation logic into the bypass branch.
Fixes #2825