Use current stable base images for Debian and Alpine #2827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nblock
commented
Oct 27, 2025
- have read the CONTRIBUTING.md file
- raised a GitHub issue or discussed it on the projects chat beforehand
- added unit tests
- added integration tests
- updated documentation if needed
- updated CHANGELOG.md
kradalby
approved these changes
Oct 27, 2025
tianon
reviewed
Nov 12, 2025
Comment on lines
11
to
12
| && rm -rf /var/lib/apt/lists/* \ | ||
| && apt-get clean |
Contributor
There was a problem hiding this comment.
FWIW, apt-get clean is a no-op in the Debian (and Ubuntu) base images
Perhaps confusingly in relation to that, APT in Trixie now supports a separate apt-get dist-clean command that's similar to this rm -rf, but better (because it keeps the cryptographic downgrade-attack-preventing verification bits).
Suggested change
| && rm -rf /var/lib/apt/lists/* \ | |
| && apt-get clean | |
| && apt-get dist-clean |
Edit: sent a PR (#2880); hopefully it's a trivial enough change to not require much discussion, but I'm happy to discuss further! ❤️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.