integration: reduce TestAutoApproveMultiNetwork matrix to 3 tests #2815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ps aux | grep approach matched both dlv debugger and headscale binary, causing 'multiple headscale processes' errors. Use pidof which only matches the actual binary name.
Reduces the test matrix from 24 combinations to 3 representative tests to avoid overwhelming Docker and disk space. The minimal set covers all key dimensions: both auth methods, all approver types, both policy modes, and both advertiseDuringUp values. Set HEADSCALE_INTEGRATION_FULL_MATRIX=1 to run all 24 tests.
juanfont
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces the test matrix from 24 combinations to 3 representative tests
to avoid overwhelming Docker and disk space. The minimal set covers all
key dimensions: both auth methods, all approver types, both policy modes,
and both advertiseDuringUp values.
Set HEADSCALE_INTEGRATION_FULL_MATRIX=1 to run all 24 tests.