Skip to content

Conversation

@nblock
Copy link
Collaborator

@nblock nblock commented Jul 23, 2025

The argument --format=colored-line-number is invalid and --out-format=colored-line-number is no longer available. Fixup according to the migration guide.

Tested this locally via:

$ nix develop
$ golangci-lint run --new-from-rev=3123d5286bbeb1d4958cec3c92d5a0969b201a9b --output.text.path=stdout --output.text.print-linter-name --output.text.print-issued-lines --output.text.colors
hscontrol/oidc.go:281:29: printf: (*github.com/rs/zerolog.Event).Msgf format %s has arg userinfo of wrong type *github.com/coreos/go-oidc/v3/oidc.UserInfo (govet)
        log.Info().Msgf("UserInfo: %s", userinfo)
                                   ^
hscontrol/oidc.go:404:33: printf: (*github.com/rs/zerolog.Event).Msgf format %s has arg oauth2Token of wrong type *golang.org/x/oauth2.Token (govet)
        log.Info().Msgf("oauth2 Token: %s", oauth2Token)
                                       ^
hscontrol/oidc.go:417:2: missing whitespace above this line (invalid statement above expr) (wsl_v5)
        log.Info().Msgf("ID Token: %s", rawIDToken)
        ^
3 issues:
* govet: 2
* wsl_v5: 1

  • have read the CONTRIBUTING.md file
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

The argument --format=colored-line-number is invalid and
--out-format=colored-line-number is no longer available. Fixup according
to the migration guide.
@nblock nblock requested a review from kradalby July 23, 2025 18:53
@nblock nblock requested a review from ohdearaugustin as a code owner July 23, 2025 18:53
@ghost
Copy link

ghost commented Jul 23, 2025

Pull Request Revisions

RevisionDescription
r1
Updated golangci-lint configuration optionsModified golangci-lint command with new output text formatting and display options for linting

✅ AI review completed for r1
Help React with emojis to give feedback on AI-generated reviews:
  • 👍 means the feedback was helpful and actionable
  • 👎 means the feedback was incorrect or unhelpful
💬 Replying to feedback with a comment helps us improve the system. Your input also contributes to shaping future interactions with the AI reviewer.

We'd love to hear from you—reach out anytime at [email protected].

@kradalby kradalby merged commit e7fe645 into juanfont:main Jul 24, 2025
84 checks passed
@nblock nblock deleted the ghlint branch July 24, 2025 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants