Skip to content

Conversation

@kradalby
Copy link
Collaborator

@kradalby kradalby commented May 9, 2025

Fixes #2568

@kradalby kradalby requested a review from juanfont as a code owner May 9, 2025 11:15
@ghost
Copy link

ghost commented May 9, 2025

Pull Request Revisions

RevisionDescription
r1
Route approval policy logic updatedModified route approval mechanism in policy manager to handle exit routes and auto-approvers more precisely, with updated logic for resolving and checking route approvals

✅ AI review completed for r1
Help React with emojis to give feedback on AI-generated reviews:
  • 👍 means the feedback was helpful and actionable
  • 👎 means the feedback was incorrect or unhelpful
💬 Replying to feedback with a comment helps us improve the system. Your input also contributes to shaping future interactions with the AI reviewer.

We'd love to hear from you—reach out anytime at [email protected].

Comment on lines +112 to +113
exitSetHash := deephash.Hash(&autoMap)
exitSetChanged := exitSetHash != pm.exitSetHash
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In hscontrol/policy/v2/policy.go, the exitSetHash is computed using deephash.Hash(&autoMap) rather than using the exitSet. Was this intentional or should it be deephash.Hash(exitSet) instead?

@kradalby kradalby merged commit 37dc0da into juanfont:main May 9, 2025
143 of 146 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] autoApprove does not work for 0.0.0.0/0 and ::/0

2 participants