Replace magic-nix-cache-action #2575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Revisions
✅ AI review completed for r1 HelpReact with emojis to give feedback on AI-generated reviews:
We'd love to hear from you—reach out anytime at [email protected]. |
ghost
approved these changes
May 9, 2025
Comment on lines
+38
to
+40
| with: | ||
| primary-key: nix-${{ runner.os }}-${{ runner.arch }}-${{ hashFiles('**/*.nix', '**/flake.lock') }} | ||
| restore-prefixes-first-match: nix-${{ runner.os }}-${{ runner.arch }} |
There was a problem hiding this comment.
The cache keys in the new nix-community/cache-nix-action configuration use hashFiles('**/*.nix', '**/flake.lock') which might be more restrictive than needed. Have you considered whether this might lead to more cache misses compared to the previous setup? The previous magic-nix-cache-action might have used different cache key strategies.
nblock
approved these changes
May 9, 2025
Collaborator
|
I think you missed the update nix workflow, can you have a look at that? |
Collaborator
We should do a follow up here. Merged because jobs broke on my drafts prs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this counts as a bug fix 😅 If not, I'm happy to close the PR and discuss the change :)
The
DeterminateSystems/magic-nix-cache-actionaction has been deprecated and no longer works. This PR replaces it with thenix-community/cache-nix-actionaction, which is actively maintained. It also replaces theDeterminateSystems/nix-installer-actionaction with thenixbuild/nix-quick-install-actionaction, which is required for the cache action to work. The cache has been configured to restore based on the runner's OS and architecture, so it should work on any runner.