Skip to content

Conversation

@nblock
Copy link
Collaborator

@nblock nblock commented May 5, 2025

Previous Headscale versions required a dedicated rule to make a subnet router visible to clients. This workaround is no longer required.

  • have read the CONTRIBUTING.md file
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

Previous Headscale versions required a dedicated rule to make a subnet
router visible to clients. This workaround is no longer required.
@nblock nblock requested a review from ohdearaugustin as a code owner May 5, 2025 11:55
@ghost
Copy link

ghost commented May 5, 2025

Pull Request Revisions

RevisionDescription
r1
Simplified ACL and routes documentationRemoved redundant network routing rules and simplified documentation for subnet router and ACL configuration in two markdown files

✅ AI review completed for r1
Help React with emojis to give feedback on AI-generated reviews:
  • 👍 means the feedback was helpful and actionable
  • 👎 means the feedback was incorrect or unhelpful
💬 Replying to feedback with a comment helps us improve the system. Your input also contributes to shaping future interactions with the AI reviewer.

We'd love to hear from you—reach out anytime at [email protected].

@nblock nblock requested a review from kradalby May 5, 2025 11:55
@kradalby
Copy link
Collaborator

kradalby commented May 5, 2025

Great 🎉

@nblock nblock merged commit 833e0f6 into juanfont:main May 5, 2025
146 checks passed
@nblock nblock deleted the router-no-access branch May 5, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants