Skip to content

Conversation

@kradalby
Copy link
Collaborator

@kradalby kradalby commented May 2, 2025

No description provided.

@ghost
Copy link

ghost commented May 2, 2025

Pull Request Revisions

RevisionDescription
r8
Removed duplicate import in test fileEliminated a redundant import of the matcher package in the policy_test.go file
r7
SSH policy reworked with new validationComprehensive refactoring of SSH policy validation with stricter rules, improved autogroup handling, and enhanced error checking across policy sources, destinations, and users.
r6
Updated Nixpkgs flake lockUpgraded Nixpkgs dependency to a newer commit with updated hash and modified lastModified timestamp
r5
Modified autogroup validation logicUpdated autogroup validation to check against a new unsupported autogroups slice instead of previous containment checks
r4
Removed autogroup:nonroot from SSH policyUpdated SSH policy test case by removing autogroup:nonroot from users and test case configurations
r3
SSH policy reworked for consistencyUpdated SSH policy to align with Tailscale upstream, modifying test cases to use specific user destinations instead of groups
r2
Skipped SSH policy test casesAdded skipV1: true to multiple SSH policy test cases due to broken group implementation in v1
r1
Added comprehensive SSH policy testsExpanded SSH policy testing in policy_test.go with multiple scenarios for SSH rule matching, validation, and policy generation across different user and tag configurations

✅ AI review completed for r8
Help React with emojis to give feedback on AI-generated reviews:
  • 👍 means the feedback was helpful and actionable
  • 👎 means the feedback was incorrect or unhelpful
💬 Replying to feedback with a comment helps us improve the system. Your input also contributes to shaping future interactions with the AI reviewer.

We'd love to hear from you—reach out anytime at [email protected].

@kradalby kradalby marked this pull request as ready for review May 3, 2025 07:10
@kradalby kradalby force-pushed the kradalby/sshv2-tests branch from 4178b6e to b22b67d Compare May 3, 2025 18:14
@kradalby kradalby requested a review from nblock May 3, 2025 18:14
@kradalby kradalby force-pushed the kradalby/sshv2-tests branch from b22b67d to ad8dd26 Compare May 3, 2025 21:04
@kradalby kradalby force-pushed the kradalby/sshv2-tests branch from d4683c1 to 47cc922 Compare May 4, 2025 07:54
@kradalby kradalby enabled auto-merge (squash) May 4, 2025 07:54
kradalby added 4 commits May 4, 2025 14:01
Signed-off-by: Kristoffer Dalby <[email protected]>
Signed-off-by: Kristoffer Dalby <[email protected]>
@kradalby kradalby force-pushed the kradalby/sshv2-tests branch from 47cc922 to 20ff0b0 Compare May 4, 2025 12:01
@kradalby kradalby merged commit b9868f6 into juanfont:main May 4, 2025
141 of 144 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants