cmd: add policy check command #2553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Revisions
✅ AI review completed for r2 HelpReact with emojis to give feedback on AI-generated reviews:
We'd love to hear from you—reach out anytime at [email protected]. |
ghost
reviewed
May 2, 2025
Signed-off-by: Kristoffer Dalby <[email protected]>
3116fa0 to
247e089
Compare
ghost
approved these changes
May 2, 2025
Comment on lines
+104
to
+112
| if err != nil { | ||
| ErrorOutput(err, fmt.Sprintf("Error opening the policy file: %s", err), output) | ||
| } | ||
| defer f.Close() | ||
|
|
||
| policyBytes, err := io.ReadAll(f) | ||
| if err != nil { | ||
| ErrorOutput(err, fmt.Sprintf("Error reading the policy file: %s", err), output) | ||
| } |
There was a problem hiding this comment.
The checkPolicy command should return after calling ErrorOutput on line 105 and 111 to prevent execution from continuing after an error occurs. Otherwise, subsequent operations might panic when operating on invalid data.
nblock
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a cli check command that tries to read in the policy and reports errors.