Skip to content

Conversation

@kradalby
Copy link
Collaborator

Fixes #2547

@kradalby kradalby requested a review from juanfont as a code owner April 30, 2025 09:40
@ghost
Copy link

ghost commented Apr 30, 2025

Pull Request Revisions

RevisionDescription
r2
Route auto-approval workflow updatedModified route auto-approval to save node after policy check, ensuring routes are properly processed and updates are sent
r1
Route auto-approval workflow refactoredModified route auto-approval process to handle database and policy manager interactions more explicitly, adding a save and notification step after route approval

✅ AI review completed for r2
Help React with emojis to give feedback on AI-generated reviews:
  • 👍 means the feedback was helpful and actionable
  • 👎 means the feedback was incorrect or unhelpful
💬 Replying to feedback with a comment helps us improve the system. Your input also contributes to shaping future interactions with the AI reviewer.

We'd love to hear from you—reach out anytime at [email protected].

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In hscontrol/auth.go, auto-approval of routes was removed from handleRegisterInteractive but still exists in handleRegisterWithAuthKey (line 217). Should this also be moved to after the node is stored in the database for consistency with the other registration flows?

Copy link
Collaborator

@nblock nblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual test with routes and exit nodes worked, thx!

@kradalby kradalby force-pushed the kradalby/web-auth-no-autoappr branch from 8c2cfc6 to 25027b2 Compare April 30, 2025 14:14
@kradalby kradalby merged commit eb1ecef into juanfont:main May 1, 2025
139 of 144 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] autoApprove does not work from start

2 participants