Skip to content

Conversation

@kradalby
Copy link
Collaborator

@kradalby kradalby commented Apr 23, 2025

Fixes #2520
Fixes #2492
Fixes #2487

@ghost
Copy link

ghost commented Apr 23, 2025

Pull Request Revisions

RevisionDescription
r9
Pre-auth key creation uses mapped userModified pre-auth key creation to use user ID from mapped users instead of hardcoded username
r8
User ID replaces username for keysThe project modified multiple files to transition pre-authentication key operations from using usernames to using user IDs. This involved updating gRPC proto definitions, CLI commands, integration tests, and various backend methods to work with user IDs as uint64 instead of string usernames.
r7
Refactored IP check and key expirationUpdated IP comparison to use slices.Contains() and modified user ID handling in key expiration command
r6
Pre-auth key uses user IDUpdated pre-authentication key API and related components to use user ID instead of username, including changes to protobuf definitions, gRPC server, CLI, and integration tests. This involves modifying type conversions, function signatures, and how users are referenced in pre-auth key operations.
r5
Pre-auth key API uses IDsMajor changes include modifying pre-auth key API and CLI to use user IDs instead of usernames, updating protobuf definitions, and adjusting related code to support numeric user identification
r4
Updated user creation and key managementModified integration tests and control interfaces to handle user creation with ID, return user objects, and use user IDs for pre-auth key creation
r3
Pre-auth key API now uses IDChanged pre-authentication key API/CLI to use numeric user ID instead of username string in multiple components
r2
Pre-auth keys now return full userAPI for pre-authentication keys modified to return complete user object instead of string representation
r1
Updated protobuf generation for v1.36.6Updated generated protobuf files with protoc-gen-go version 1.36.6, including changes to PreAuthKey to use User type instead of username string

✅ AI review completed for r9
Help React with emojis to give feedback on AI-generated reviews:
  • 👍 means the feedback was helpful and actionable
  • 👎 means the feedback was incorrect or unhelpful
💬 Replying to feedback with a comment helps us improve the system. Your input also contributes to shaping future interactions with the AI reviewer.

We'd love to hear from you—reach out anytime at [email protected].

@kradalby kradalby force-pushed the kradalby/2520-auth-key-user branch from b5d1be0 to ab6b743 Compare April 23, 2025 11:39
@kradalby kradalby marked this pull request as ready for review April 24, 2025 12:36
@kradalby kradalby force-pushed the kradalby/2520-auth-key-user branch from ec58eb5 to d91d185 Compare April 29, 2025 15:11
@kradalby kradalby force-pushed the kradalby/2520-auth-key-user branch from d91d185 to 507a703 Compare April 30, 2025 07:47
Signed-off-by: Kristoffer Dalby <[email protected]>
Signed-off-by: Kristoffer Dalby <[email protected]>
@kradalby kradalby force-pushed the kradalby/2520-auth-key-user branch from 507a703 to e785577 Compare April 30, 2025 08:54
@kradalby kradalby force-pushed the kradalby/2520-auth-key-user branch from e785577 to 9f099cc Compare April 30, 2025 08:55
@kradalby kradalby merged commit 8f9fbf1 into juanfont:main Apr 30, 2025
139 of 144 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants