-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add documentation for routes #2496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5797d31 to
20e2f78
Compare
Pull Request Revisions
✅ AI review completed for r2 HelpReact with emojis to give feedback on AI-generated reviews:
We'd love to hear from you—reach out anytime at [email protected]. |
* Rename exit-node to routes and add redirects * Add a new section on subnet routers * Extend the existing exit-node documentation * Describe auto approvers for subnet routers and exit nodes * Provide ACL examples for subnet routers and exit nodes * Describe HA and its current limitations * Add a troubleshooting section with IP forwarding
Add auto approvers and link to our documentation if available.
| // more rules | ||
| ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The JSON comments in the ACL examples (lines 137-138 and 255-256) use JavaScript-style comments (// more rules). JSON doesn't technically support comments, so while this works for documentation, it might be confusing if users try to copy and paste these examples directly. Consider using a proper JSON format or adding a note that these comments should be removed before use.
kradalby
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!, thank you!
Uh oh!
There was an error while loading. Please reload this page.