Skip to content

Conversation

@kradalby
Copy link
Collaborator

Fixes #2479

@kradalby kradalby added this to the v0.26.0 milestone Mar 27, 2025
@kradalby kradalby removed this from the v0.26.0 milestone Apr 30, 2025
Signed-off-by: Kristoffer Dalby <[email protected]>
@kradalby kradalby force-pushed the kradalby/error-on-undef-hostname branch from 8da5a87 to f4a13b3 Compare April 30, 2025 11:39
@ghost
Copy link

ghost commented Apr 30, 2025

Pull Request Revisions

RevisionDescription
r1
Added policy validation for hostsIntroduced validate() method to check host references in policy, renaming policyFromBytes() to unmarshalPolicy() with additional validation step

☑️ AI review skipped for r1
Help React with emojis to give feedback on AI-generated reviews:
  • 👍 means the feedback was helpful and actionable
  • 👎 means the feedback was incorrect or unhelpful
💬 Replying to feedback with a comment helps us improve the system. Your input also contributes to shaping future interactions with the AI reviewer.

We'd love to hear from you—reach out anytime at [email protected].

@kradalby kradalby marked this pull request as ready for review April 30, 2025 11:40
@kradalby kradalby requested a review from juanfont as a code owner April 30, 2025 11:40
@kradalby kradalby closed this May 1, 2025
@kradalby kradalby reopened this May 1, 2025
@kradalby kradalby enabled auto-merge (squash) May 1, 2025 05:06
@kradalby kradalby merged commit c923f46 into juanfont:main May 1, 2025
276 of 286 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Error out on unknown symbol for policy v2

2 participants