Fixing IPv6 Parsing in ACLs #1470
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Please also add a test case for the integration tests. |
Contributor
Author
|
@kradalby, done |
Contributor
Author
|
Hello @kradalby, would it be possible to merge this at your earliest convenience? I have noticed numerous code changes occurring, and anticipate even more in the future. A prompt merge could help avoid potential conflict resolution. |
Collaborator
|
Can you make this a PR into my branch here: https://github.com/kradalby/headscale/tree/corereorg-p3 ? Or you can rebase on top of that when that branch is finished. It will probably be quite some time still. |
Contributor
Author
|
@kradalby, sure, here it is - kradalby#6 |
Collaborator
|
Closing this as it will be a part of #1477 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses a bug found in the ACLs' handling of IPv6 addresses. Previously, the ACLs would fail to correctly parse IPv6 addresses, especially those with network prefixes attached (CIDR notation).
The result of these changes is an improved ability to parse IPv6 addresses, including those with network prefixes attached.