Skip to content

Conversation

@anr2me
Copy link
Collaborator

@anr2me anr2me commented Jun 21, 2025

Fixes fullscreen issue on vulkan #20508

Thanks to @Samueru-sama for the help.

@anr2me
Copy link
Collaborator Author

anr2me commented Jun 21, 2025

A strange error on windows test O.o seems to be unrelated to this PR.

@anr2me anr2me linked an issue Jun 21, 2025 that may be closed by this pull request
5 tasks
@hrydgard
Copy link
Owner

Re-running the windows test.

I guess we should upgrade to SDL3 at some point but it's still a bit too new for my taste.

@anr2me
Copy link
Collaborator Author

anr2me commented Jun 21, 2025

Strange that the windows test is always failing 🤔 This PR didn't even changed the source code nor the build.yml 😂

@anr2me
Copy link
Collaborator Author

anr2me commented Jun 25, 2025

I think we can get this in for now, since it will probably took a long time before we migrate to SDL3 😅

But this only fixes the vulkan issue on AppImage version, while the standard binary on ubuntu-latest artifacts might still have the issue. (Did Ubuntu latest also use SDL3 with SDL2-compat by default? 🤔) May be the SDL2 library on Ubuntu wasn't the latest version and still have the bug🤔

@AmandaRoseChaqueta
Copy link

Tested on Arch Linux. Seems to be working great!
Screenshot_20250625_151555

@hrydgard hrydgard merged commit 4ad10d9 into hrydgard:master Jun 25, 2025
74 of 78 checks passed
@hrydgard hrydgard added this to the 1.19.3 milestone Jun 25, 2025
@anr2me anr2me deleted the appimage-sdl2 branch June 25, 2025 21:35
hrydgard added a commit that referenced this pull request Jul 10, 2025
Use SDL2 library instead of SDL2-compat with SDL3 library.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Graphics issues in PPSSPP 1.19.1 (Appimage)

3 participants