Skip to content

Conversation

@hembhagat99
Copy link
Contributor

@hembhagat99 hembhagat99 commented Nov 5, 2025

Proposed change

Move URL out of strings.json for ntfy integration.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hembhagat99

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

home-assistant bot commented Nov 5, 2025

Hey there @tr4nt0r, mind taking a look at this pull request as it has been labeled with an integration (ntfy) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of ntfy can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign ntfy Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@hembhagat99 hembhagat99 marked this pull request as ready for review November 26, 2025 17:11
@hembhagat99
Copy link
Contributor Author

@joostlek, can you please review?

@tr4nt0r
Copy link
Contributor

tr4nt0r commented Nov 26, 2025

@hembhagat99 please don't ping people, it is sufficient to mark your PR as ready for review https://developers.home-assistant.io/docs/review-process/#what-not-to-do

@hembhagat99
Copy link
Contributor Author

@hembhagat99 please don't ping people, it is sufficient to mark your PR as ready for review https://developers.home-assistant.io/docs/review-process/#what-not-to-do

Thanks for the clarification! I appreciate the guidance. I’ll avoid this in the future. I only reached out because the PR had been in draft for a while, but I understand the process now.

@frenck
Copy link
Member

frenck commented Nov 27, 2025

I've marked this PR a draft, as changes are requested that need to be processed.
Please un-draft it once it is ready for review again by clicking the "Ready for review" button.

Thanks! 👍

../Frenck

Learn more about our pull request process.

@frenck frenck marked this pull request as draft November 27, 2025 09:55
@hembhagat99 hembhagat99 marked this pull request as ready for review November 27, 2025 17:12
Copy link
Member

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hembhagat99 👍

@edenhaus edenhaus dismissed stale reviews from home-assistant[bot] and tr4nt0r December 3, 2025 13:14

stale

@edenhaus edenhaus requested a review from tr4nt0r December 3, 2025 13:15
@jbouwh jbouwh merged commit c333036 into home-assistant:dev Dec 4, 2025
36 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants