-
-
Notifications
You must be signed in to change notification settings - Fork 36.5k
Move translatable URL out of strings.json for ntfy integration #155859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @hembhagat99
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
|
Hey there @tr4nt0r, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
285c654 to
e5b0b0e
Compare
|
@joostlek, can you please review? |
|
@hembhagat99 please don't ping people, it is sufficient to mark your PR as ready for review https://developers.home-assistant.io/docs/review-process/#what-not-to-do |
Thanks for the clarification! I appreciate the guidance. I’ll avoid this in the future. I only reached out because the PR had been in draft for a while, but I understand the process now. |
|
I've marked this PR a draft, as changes are requested that need to be processed. Thanks! 👍 ../Frenck |
edenhaus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hembhagat99 👍
Proposed change
Move URL out of
strings.jsonforntfyintegration.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: