Skip to content

Conversation

@siduck
Copy link
Contributor

@siduck siduck commented Nov 25, 2025

Copy link
Member

@surajshetty3416 surajshetty3416 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@siduck, you should ideally replace usages of Autocomplete example inside frappe-ui with Combobox. Otherwise, people using frappe-ui will keep getting these warnings, and they can’t do anything about it since it’s internal.

@netchampfaris
Copy link
Contributor

@siduck

https://github.com/frappe/frappe-ui/wiki/Guide-to-Migrate-Autocomplete-component-to-Combobox-&-MultiSelect

This guide is incomplete without mentioning what the breaking changes were. for e.g., Autocomplete used to set the { label, value } object as the value but Combobox sets the primitive "value" as the value. so devs will have to make more than just template changes. they will have to update script section as well. you should add full examples for Combobox and MultiSelect migrating from Autocomplete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate Autocomplete

4 participants