feat: validate entity types before navigation #499
Conversation
|
@SharanRP thanks for this PR! I'll merge this, but could you clean up the code a bit - for example, refactor the three functions into one uniform one? |
|
Have made the changes |
|
Sharan, I'm sorry - I should have realized this earlier. But this is not a good way to solve the issue, because we're adding an extra server call for every route. Instead Do you want to take this up? |
|
Yes, thank you for the guidance ,I’ll make the necessary changes. |
|
@safwansamsudeen can you check this once |
drive/api/permissions.py
Outdated
|
|
||
| @frappe.whitelist(allow_guest=True) | ||
| def get_entity_with_permissions(entity_name): | ||
| def get_entity_with_permissions(entity_name, expected_type=None): |
There was a problem hiding this comment.
This isn't a good paradigm - instead, could you analyze the route and get the file type?
frontend/src/pages/Document.vue
Outdated
| entity_name: props.entityName, | ||
| expected_type: "document", | ||
| }, | ||
| transform(entity) { |
There was a problem hiding this comment.
Should be done in onSuccess, not transform
|
|
||
|
|
||
| @frappe.whitelist(allow_guest=True) | ||
| def get_entity_type(entity_name): |
There was a problem hiding this comment.
Why was this deleted?
safwansamsudeen
left a comment
There was a problem hiding this comment.
Hey, could you make the requested changes? Reach out @realsafwan in Telegram if you need some help.
…e, folder, and document components
closes #475