[Android] fix: network call timeout

[troZee]

Summary:

This PR is a continuation of this #29471. All context you can find here:

axios/axios#2073 (comment)
axios/axios#2073 (comment)

Changelog:

[ANDROID] [FIXED] - change connectTimeout to callTimeout in OKHttp client

Test Plan:

• Throttle internet connection (You can use GSM one)

import axios from "axios";

axios.get('https://jsonplaceholder.typicode.com/users', {
  timeout: 5000
})
.then(response => {
  console.log(response.data);
})
.catch(error => {
  if (error.code === 'ECONNABORTED') {
    console.log('Request timed out');
  } else {
    console.log(error.message);
  }
});

Expected result

Request timed out should be visible in a console

Videos

Before

Before.mov

After

After.mov

Example URL

Branch:
https://github.com/troZee/react-native/tree/fix/network-timeout-example

Commit:
https://github.com/troZee/react-native/commit/e255e1a423143c4bd4f3e37656a56ba2ecbbf3e2

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,947,045	+3
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	9,540,850	+44
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: ae88aef
Branch: main

[NickGerleman]

I looked through to see what is piping timeout to native, and confirmed new behavior is the expectation for XMLHttpRequest timeout prop (fetch just polyfills that). So, change LGTM.

[facebook-github-bot]

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[NickGerleman]

This line is no longer correct (should be callTimeoutMillis()). I can fix it up quickly.

[Marco29001]

how change this line?

[NickGerleman]

It looks like RN is internally built using okhttp 3.6.0, which is way behind OSS, and doesn't yet have these APIs (they are introduced in 3.12.0). I will take a look at how painful it would be to bump this dependency in internal apps.

[troZee]

Hey 👋
Thank you @NickGerleman for checking that issue. Could we plan a migration from 3.6.0 to 3.12.0? Could you estimate, if this migration is complex to do? Maybe we should consider creating a separate task to bump the oss version and the internal one to https://github.com/square/okhttp/tree/parent-3.14.9 ?

Moreover, https://square.github.io/okhttp/changelogs/changelog_3x/#version-3149 has 2 years and maybe we should consider migrating it to the newest one https://square.github.io/okhttp/changelogs/changelog_4x/#version-4100 ?

[github-actions]

This pull request was successfully merged by @troZee in e00f244.

^{When will my fix make it into a release? | Upcoming Releases}

[hasan642]

I changed the lines you mentioned and still not working!
@NickGerleman

is working with you? @Marco29001

[Marco29001]

I tested this with a pre-release version and if the timeout issue mentioned in this PR works, but there is still an issue that I think is related to this issue, what happens is that if the connection is lost for a long time when I recover it, it happens to me. I can't make a new request until a certain amount of time passes, this only happens on Android
@hasan642

[hasan642]

@Marco29001 we need a solution please
Axios android duplicates request to 5 times .

[troZee]

@Marco29001 @hasan642 could you provide a repro for that?
Here I could not reproduce that