Allow moving existing widgets to the top of interaction stack #7805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview available at https://egui-pr-preview.github.io/pr/7805-emilkmove-interaction-to-top View snapshot changes at kitdiff |
lucasmerlin
reviewed
Jan 2, 2026
Comment on lines
+197
to
+199
| layer_widgets.remove(*idx_in_layer); | ||
| *idx_in_layer = layer_widgets.len(); | ||
| layer_widgets.push(*existing); |
Collaborator
There was a problem hiding this comment.
layer_widgets.remove changes the index of the following widgets in this layer, meaning they now have the wrong index in the by_id map 😕
This should be the cause of #7812
emilk
pushed a commit
that referenced
this pull request
Jan 5, 2026
* closes #7812 * related #7805 That pr introduced a bug that caused a mismatch in the `by_layer` / `by_id` widget rects. This should fix it by updating the index of all following widgets. Not super pretty and efficient, but I'm not sure if there's a better way. Maybe we could also just leave a "tombstone" / duplicate there in the by_layer map so we don't need to update the indexes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
Ui::interact_optwhich is a version ofUi::interactthat lets you specify that if this widget already exists, it should be moved to the top of the interaction stack.This lets you easily more easily "read a response from the future", by simply calling interact twice, instead of calling
Context::read_response.