-
Notifications
You must be signed in to change notification settings - Fork 117
feat: add page_no to TableCell #467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add page_no to TableCell #467
Conversation
|
✅ DCO Check Passed Thanks @ryyhan, all your commits are properly signed off. 🎉 |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🔴 Require two reviewer for test updatesThis rule is failing.When test data is updated, we require two reviewers
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
|
@ryyhan Thanks for this PR. I think it makes sense to keep track of the page number (when available) in table cells. |
Signed-off-by: ryyhan <[email protected]>
54fd775 to
67365e1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ceberam
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you for the review and approval, @ceberam! I'm glad the changes look good. |
|
@dolfim-ibm / @PeterStaar-IBM could you also please take a look when you have a moment? We need a second approval for the test updates to merge this. |
|
@ryyhan I am not sure about this, it looks like a patch instead of a proper solution |
Description
Resolves #410.
Adds
page_noattribute to the TableCell class to support cross-page table data as requested. This allows upstream parsers to store page location information for individual cells in multi-page tables.Changes
page_no.Type of change
Checklist