-
Notifications
You must be signed in to change notification settings - Fork 117
feat(DocItem): Add comments field for linking annotations to document… #465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(DocItem): Add comments field for linking annotations to document… #465
Conversation
… items Implements support for linking comments (from Word/PPT documents) to their annotated content using the established FloatingItem/RefItem pattern. Changes: - Add `comments: List[RefItem]` field to DocItem class - Update `_update_breadth_first_with_lookup()` to handle comment references on deletion - Bump CURRENT_VERSION to 1.9.0 - Fix version comparison bug (string vs integer for minor version) - Add 4 new tests for comments functionality - Update test data files for new schema Closes: docling-project/docling#464 Related: docling-project/docling#2834 Signed-off-by: s1v4-d <[email protected]>
|
✅ DCO Check Passed Thanks @s1v4-d, all your commits are properly signed off. 🎉 |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 Require two reviewer for test updatesWonderful, this rule succeeded.When test data is updated, we require two reviewers
|
Signed-off-by: Panos Vagenas <[email protected]>
Signed-off-by: Panos Vagenas <[email protected]>
Signed-off-by: Panos Vagenas <[email protected]>
Signed-off-by: Panos Vagenas <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
vagenas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added couple improvements:
- introduced fine-granular references (
FineRef) including span ranges - extended API with
add_comment()operation encapsulating all relevant labels etc. - improved serialization to suppress empty
.commentslists (most common case)
docling-project#465) * feat(DocItem): Add comments field for linking annotations to document items Implements support for linking comments (from Word/PPT documents) to their annotated content using the established FloatingItem/RefItem pattern. Changes: - Add `comments: List[RefItem]` field to DocItem class - Update `_update_breadth_first_with_lookup()` to handle comment references on deletion - Bump CURRENT_VERSION to 1.9.0 - Fix version comparison bug (string vs integer for minor version) - Add 4 new tests for comments functionality - Update test data files for new schema Closes: docling-project/docling#464 Related: docling-project/docling#2834 Signed-off-by: s1v4-d <[email protected]> * improve comment Pydantic serialization Signed-off-by: Panos Vagenas <[email protected]> * add add_comment, update tests Signed-off-by: Panos Vagenas <[email protected]> * introduce fine-granular references with span ranges Signed-off-by: Panos Vagenas <[email protected]> * simplify last test Signed-off-by: Panos Vagenas <[email protected]> --------- Signed-off-by: s1v4-d <[email protected]> Signed-off-by: Panos Vagenas <[email protected]> Co-authored-by: Panos Vagenas <[email protected]>
… items
Implements support for linking comments (from Word/PPT documents) to their annotated content using the established FloatingItem/RefItem pattern.
Changes:
comments: List[RefItem]field to DocItem class_update_breadth_first_with_lookup()to handle comment references on deletionCloses: docling-project/docling#464
Related: docling-project/docling#2834