dbeaver/pro#5145 add rename action for connection #4041
+22
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeyteleshev
approved these changes
Jan 11, 2026
Wroud
reviewed
Jan 12, 2026
Comment on lines
+309
to
+315
| if (node.objectFeatures.includes(EObjectFeature.dataSource)) { | ||
| return node.id; | ||
| } | ||
|
|
||
| const parts = node.id.split('/'); | ||
| parts.splice(parts.length - 1, 1, name); | ||
| const path = parts.join('/'); |
Member
There was a problem hiding this comment.
if it possible we should avoid such conditions in the generic places
Member
Author
There was a problem hiding this comment.
We can ignore it on the subscription level, but then we need to do it in every place, the connection node is just a node which id behaves differently when renaming, i think it would be strange to submit event with invalid nodeId,
I think the best optoin is to return new id from backend
Member
There was a problem hiding this comment.
agree, best option is to get new id from the backend
Comment on lines
-116
to
+117
| return node.features?.includes(ENodeFeature.canRename) ?? false; | ||
| return (node.features?.includes(ENodeFeature.canRename) || node.objectFeatures.includes(EObjectFeature.dataSource)) ?? false; |
Member
There was a problem hiding this comment.
seems strange, why backend will not send canRename feature?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes 5145