dbeaver/pro#4999 Data editor icons to see pk details #4040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tooltips for key detection
…y connection state and improve tooltips
sergeyteleshev
approved these changes
Jan 9, 2026
Wroud
requested changes
Jan 12, 2026
|
|
||
| const firstColumn = tableDataContext.columns[1]; | ||
| const firstColumnData = | ||
| firstColumn?.key !== null && firstColumn?.key !== undefined |
Member
There was a problem hiding this comment.
Suggested change
| firstColumn?.key !== null && firstColumn?.key !== undefined | |
| isNotNullDefined(firstColumn?.key) |
| {readonly && ( | ||
| <IconOrImage title={translate('data_grid_table_readonly_tooltip')} icon="/icons/lock.png" className={s(styles, { iconOrImage: true })} /> | ||
| )} | ||
| <TableStatusIndicator readOnlyConnection={dataGridContext.model.isReadonly(dataGridContext.resultIndex)} /> |
Member
There was a problem hiding this comment.
seems like this prop not needed, component itself uses dataGridContext and can retrieve this information by itself
Comment on lines
+87
to
+93
| <div | ||
| className={clsx( | ||
| 'tw:w-3 tw:h-3 tw:rounded-full tw:shrink-0 tw:bg-transparent tw:border', | ||
| "tw:before:content-[''] tw:before:block tw:before:w-1.5 tw:before:h-1.5 tw:before:rounded-full tw:before:m-0.5", | ||
| `tw:border-(--theme-${themeColor}) tw:before:bg-(--theme-${themeColor})`, | ||
| )} | ||
| /> |
Member
There was a problem hiding this comment.
do we really need to always show this indicator? if table is normal table without restrictions and limitations, what the purpose of this indicator?
Contributor
Author
There was a problem hiding this comment.
To show the primary key of a table
Comment on lines
+48
to
+70
| if (readOnlyConnection) { | ||
| tooltipParts.push(translate('data_grid_table_readonly_connection_tooltip')); | ||
| } | ||
|
|
||
| if (readOnlyStatus) { | ||
| if (!readOnlyConnection) { | ||
| tooltipParts.push(translate('data_grid_table_readonly_tooltip')); | ||
| } | ||
| tooltipParts.push(readOnlyStatus); | ||
| } | ||
|
|
||
| if (hasRowIdentifier) { | ||
| // TEMPORARY: Detect primary key by checking for required and not read-only columns | ||
| // TODO: Remove when backend provides the information | ||
| const pkColumn = tableDataContext.columns.find(col => { | ||
| const colData = col.key && (tableDataContext.data.getColumn(col.key) as SqlResultColumn | undefined); | ||
| return colData?.required && !colData?.readOnly; | ||
| })?.key; | ||
|
|
||
| if (pkColumn) { | ||
| tooltipParts.push(`Unique key: ${(tableDataContext.data.getColumn(pkColumn) as SqlResultColumn | undefined)?.name}`); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
i'm not sure that it's good idea to try to implement this logic on frontend, because it might be different from dbeaver or incomplete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For read-only connection we write "Read-only connection" in the tooltip,
If. there is other reason, we just write "Read-only" with the reason on the next line