dbeaver/pro#7897 add connection view plugin #4031

devnaumov · 2026-01-05T21:52:50Z

closes 7897

…r-connection-view

Wroud · 2026-01-13T09:56:18Z

server/bundles/io.cloudbeaver.server/schema/service.core.graphqls

    navigatorSettings: NavigatorSettings!
+    "Original navigator settings from the configuration file"
+    originalNavigatorSettings: NavigatorSettings! @since(version: "25.3.3")


actually you can add optional argument for the navigatorSettings field, something like:

navigatorSettings(datasourceSettings: Boolean): NavigatorSettings!

userSettings should be removed from the NavigatorSettingsInput type, instead you need to add similar argument to the setConnectionNavigatorSettings

originalNavigatorSettings better to rename to the datasourceNavigatorSettings

Wroud · 2026-01-13T10:14:25Z

webapp/packages/core-sdk/src/queries/fragments/DatabaseConnectionNavigatorViewSettings.gql

+  originalNavigatorSettings {
+    ...AllNavigatorSettings
+  }


probably you need to split it into two fragments and two resources, because originalNavigatorSettings needed only for connection editing form

Copilot

Pull request overview

This PR extracts connection view functionality from plugin-connections into a new dedicated plugin plugin-connection-view. The change refactors view settings management for database connections, allowing users to configure simple/advanced views and system object visibility.

Changes:

Created new @cloudbeaver/plugin-connection-view plugin with dedicated services, resources, and UI components
Moved connection view menu actions and handlers from plugin-connections to the new plugin
Updated GraphQL schema to include originalNavigatorSettings field and added new queries/mutations for view settings
Enhanced backend logic to handle user-specific settings for shared projects

Reviewed changes

Copilot reviewed 53 out of 54 changed files in this pull request and generated 11 comments.

Show a summary per file

File	Description
webapp/packages/plugin-connection-view/*	New plugin package with connection view functionality including services, resources, UI components, and localization
webapp/packages/plugin-connections/src/ContextMenu/ConnectionMenuBootstrap.ts	Removed connection view menu logic (moved to new plugin)
webapp/packages/plugin-connections/src/ConnectionForm/*	Added connection container placeholder for view settings in connection form
webapp/packages/core-sdk/src/queries/*	Updated GraphQL fragments and queries to support separate navigator view settings
webapp/packages/core-connections/src/ConnectionInfoResource.ts	Removed changeConnectionView method (moved to new resource)
webapp/packages/plugin-navigation-tree/src/locales/*	Removed old connection view locale keys (moved to new plugin)
server/bundles/io.cloudbeaver.server/*	Enhanced backend to properly handle user settings for shared projects

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-13T10:28:44Z

webapp/packages/plugin-connection-view/src/locales/vi.ts

+  ['plugin_connection_view_option_advanced', 'Nâng cao'],
+  ['plugin_connection_view_option_custom', 'Tùy chỉnh'],
+  ['plugin_connection_view_option_show_system_objects', 'Hiển thị đối tượng hệ thống'],
+  ['plugin_connection_view_option_reset_description', 'This will reset the connection view settings to default values'],


The reset description is not translated to Vietnamese. All other languages have English text for this key, but this should be translated consistently with the rest of the file.

Copilot · 2026-01-13T10:28:44Z

webapp/packages/plugin-connection-view/src/locales/fr.ts

+  ['plugin_connection_view_option_simple', 'Simple'],
+  ['plugin_connection_view_option_advanced', 'Avancée'],
+  ['plugin_connection_view_option_custom', 'Personnalisée'],
+  ['plugin_connection_view_option_reset_description', 'This will reset the connection view settings to default values'],


The reset description is not translated to French. All other languages have English text for this key, but this should be translated consistently with the rest of the file.

Copilot · 2026-01-13T10:28:45Z

webapp/packages/plugin-connection-view/src/ConnectionViewResource.ts

+  protected validateKey(key: IConnectionInfoParams): boolean {
+    const parse = CONNECTION_INFO_PARAM_SCHEMA.safeParse(toJS(key));
+    if (!parse.success) {
+      this.logger.warn(`Invalid resource key ${(schemaValidationError(parse.error).toString(), { prefix: null })}`);


There's a syntax error in the logger.warn call. The expression has unbalanced parentheses - the schemaValidationError call result is being passed to toString() but then there's an extra comma and object literal that doesn't fit the function signature correctly.

Suggested change

this.logger.warn(`Invalid resource key ${(schemaValidationError(parse.error).toString(), { prefix: null })}`);

this.logger.warn(`Invalid resource key ${schemaValidationError(parse.error, { prefix: null }).toString()}`);

Copilot · 2026-01-13T10:28:45Z

webapp/packages/plugin-connection-view/src/locales/zh.ts

+export default [
+  ['plugin_connection_view_option_simple', '简单'],
+  ['plugin_connection_view_option_advanced', '完善'],
+  ['plugin_connection_view_option_custom', '自定义'],
+  ['plugin_connection_view_option_show_system_objects', '展示系统对象'],
+  ['plugin_connection_view_option_reset_description', 'This will reset the connection view settings to default values'],
+];


The 'plugin_connection_view' key is missing from this locale file, while it exists in other locale files (vi.ts, ru.ts, it.ts, fr.ts, en.ts). This will cause the connection view menu to display an untranslated key.

Copilot · 2026-01-13T10:28:45Z

webapp/packages/plugin-connection-view/src/ConnectionViewPluginBootstrap.ts

+        }
+
+        const node = context.get(DATA_CONTEXT_NAV_NODE)!;
+        return node.objectFeatures.includes(EObjectFeature.dataSource);


The menu is only shown for nodes with the 'dataSource' feature, but the old implementation also checked for 'dataSourceConnected'. This change means the menu will now appear for disconnected data sources as well. This could lead to user confusion or errors when trying to change view settings on disconnected connections. Consider whether this behavior change is intentional.

Suggested change

return node.objectFeatures.includes(EObjectFeature.dataSource);

return (

node.objectFeatures.includes(EObjectFeature.dataSource)

&& node.objectFeatures.includes(EObjectFeature.dataSourceConnected)

);

Copilot · 2026-01-13T10:28:46Z

webapp/packages/plugin-connection-view/src/locales/it.ts

+  ['plugin_connection_view_option_advanced', 'Avanzata'],
+  ['plugin_connection_view_option_custom', 'Personalizzata'],
+  ['plugin_connection_view_option_show_system_objects', 'Mostra oggetti di sistema'],
+  ['plugin_connection_view_option_reset_description', 'This will reset the connection view settings to default values'],


The reset description is not translated to Italian. All other languages have English text for this key, but this should be translated consistently with the rest of the file.

Copilot · 2026-01-13T10:28:46Z

webapp/packages/plugin-connection-view/src/locales/ru.ts

+export default [
+  ['plugin_connection_view', 'Отображение'],
+  ['plugin_connection_view_option_simple', 'Упрощенное'],
+  ['plugin_connection_view_option_advanced', 'Продвинутое'],
+  ['plugin_connection_view_option_show_system_objects', 'Показывать системные объекты'],
+  ['plugin_connection_view_option_reset_description', 'Это сбросит настройки отображения подключения к значениям по умолчанию'],
+];


The 'plugin_connection_view_option_custom' key is missing from this locale file, while it exists in other locale files (zh.ts, vi.ts, it.ts, fr.ts). This will cause inconsistent display when the custom option is needed.

Copilot · 2026-01-13T10:28:47Z

webapp/packages/plugin-connection-view/src/locales/en.ts

+export default [
+  ['plugin_connection_view', 'Connection view'],
+  ['plugin_connection_view_option_simple', 'Simple'],
+  ['plugin_connection_view_option_advanced', 'Advanced'],
+  ['plugin_connection_view_option_show_system_objects', 'Show system objects'],
+  ['plugin_connection_view_option_reset_description', 'This will reset the connection view settings to default values'],
+];


The 'plugin_connection_view_option_custom' key is missing from this locale file, while it exists in other locale files (zh.ts, vi.ts, it.ts, fr.ts). This will cause inconsistent display when the custom option is needed.

Copilot · 2026-01-13T10:28:47Z

webapp/packages/plugin-connection-view/src/locales/fr.ts

+export default [
+  ['plugin_connection_view', 'Vue de connexion'],
+  ['plugin_connection_view_option_simple', 'Simple'],
+  ['plugin_connection_view_option_advanced', 'Avancée'],
+  ['plugin_connection_view_option_custom', 'Personnalisée'],
+  ['plugin_connection_view_option_reset_description', 'This will reset the connection view settings to default values'],
+];


The 'plugin_connection_view_option_show_system_objects' key is missing from this locale file, while it exists in other locale files. This will cause the "Show system objects" option to display an untranslated key in French.

Copilot · 2026-01-13T10:28:47Z

webapp/packages/plugin-connection-view/src/ConnectionViewResource.ts

+
+  protected async loader(
+    originalKey: ResourceKey<IConnectionInfoParams>,
+    _: any,


The second parameter is named with just an underscore ('_'), which is acceptable but the name could be more descriptive. Consider using a more meaningful name like 'includes' or at minimum '_includes' to indicate what this parameter represents in the loader signature.

Suggested change

_: any,

_includes: any,

devnaumov and others added 14 commits January 5, 2026 22:51

dbeaver/pro#7897 add connection view plugin

dfc2ad8

Merge branch 'devel' into dbeaver/pro#7897-user-connection-view

76616b5

dbeaver/pro#7897 add view settings to the connection dialog

69ef685

dbeaver/pro#7897 navigator settings as separate resource

a0b1e38

Merge remote-tracking branch 'origin/devel' into dbeaver/pro#7897-use…

dd4ef17

…r-connection-view

Merge remote-tracking branch 'origin/devel' into dbeaver/pro#7897-use…

1726441

…r-connection-view

Merge remote-tracking branch 'origin/devel' into dbeaver/pro#7897-use…

c607664

…r-connection-view

dbeaver/pro#7897 api for original navigator settings config

5be6e3b

dbeaver/pro#7897 use original settings for connection dialog

2d8f714

dbeaver/pro#7897 save connection view fixes

66f97e0

dbeaver/pro#7897 update node on reset

7e57881

dbeaver/pro#7897 remove extra comments

feffcbb

dbeaver/pro#7897 do not update node if only global settings had changed

918c398

dbeaver/pro#7897 reuse view

6bfe2eb

devnaumov requested review from SychevAndrey, Wroud and sergeyteleshev and removed request for sergeyteleshev January 12, 2026 18:11

devnaumov marked this pull request as ready for review January 12, 2026 18:11

sergeyteleshev requested a review from Copilot January 13, 2026 10:24

Copilot started reviewing on behalf of sergeyteleshev January 13, 2026 10:24 View session

Wroud requested changes Jan 13, 2026

View reviewed changes

Copilot AI reviewed Jan 13, 2026

View reviewed changes

	this.logger.warn(`Invalid resource key ${(schemaValidationError(parse.error).toString(), { prefix: null })}`);
	this.logger.warn(`Invalid resource key ${schemaValidationError(parse.error, { prefix: null }).toString()}`);

dbeaver/pro#7897 add connection view plugin #4031

Are you sure you want to change the base?

dbeaver/pro#7897 add connection view plugin #4031

Uh oh!

Conversation

devnaumov commented Jan 5, 2026

Uh oh!

Wroud Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Wroud Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Wroud Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants