-
-
Notifications
You must be signed in to change notification settings - Fork 750
Python 3.14 support #9169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
crusaderky
wants to merge
8
commits into
dask:main
Choose a base branch
from
crusaderky:py314
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+85
−20
Open
Python 3.14 support #9169
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
8e7f1fa
Python 3.14 support
crusaderky 58f8bbc
lint
crusaderky 517c985
Increase nest level
crusaderky d82a4d0
Increase again
crusaderky 17738b9
Bump env to match #9172
crusaderky b59a2f7
Revert MacOS changes
crusaderky 19ca8e4
Use gilknocker from conda-forge
crusaderky 342496d
Merge branch 'main' into py314
crusaderky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| name: dask-distributed-313 | ||
| channels: | ||
| - conda-forge | ||
| dependencies: | ||
| - python=3.14 | ||
| - packaging | ||
| - pip | ||
| - asyncssh | ||
| - bokeh>3 | ||
| - click | ||
| - cloudpickle | ||
| - coverage | ||
| - dask # overridden by git tip below | ||
| - fsspec # overridden by git tip below | ||
| # - gilknocker # conda-forge package not yet available for Python 3.14 | ||
| - h5py | ||
| - ipykernel | ||
| - ipywidgets | ||
| - jinja2 | ||
| - jupyter_events | ||
| - jupyter-server-proxy | ||
| - jupyterlab | ||
| - locket | ||
| - msgpack-python | ||
| - netcdf4 | ||
| - paramiko | ||
| - pre-commit | ||
| - prometheus_client | ||
| - psutil | ||
| - pyarrow | ||
| - pytest | ||
| - pytest-cov | ||
| - pytest-faulthandler | ||
| - pytest-repeat | ||
| - pytest-rerunfailures | ||
| - pytest-timeout | ||
| - requests | ||
| - scikit-learn | ||
| - scipy | ||
| - sortedcollections | ||
| - tblib | ||
| - toolz | ||
| - tornado | ||
| - zict # overridden by git tip below | ||
| - zstandard | ||
| - pip: | ||
| - git+https://github.com/dask/dask | ||
| - git+https://github.com/dask/zict | ||
| - git+https://github.com/fsspec/filesystem_spec | ||
| - keras | ||
| - gilknocker # conda-forge package not yet available for Python 3.14 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3250,8 +3250,20 @@ def _get_computation_code( | |
| "|".join([f"(?:{mod})" for mod in ignore_modules]) | ||
| ) | ||
| if ignore_files: | ||
| # Given ignore-files = [foo], match: | ||
| # /path/to/foo | ||
| # /path/to/foo.py[c] | ||
| # /path/to/foo/bar.py[c] | ||
| # \path\to\foo | ||
| # \path\to\foo.py[c] | ||
| # \path\to\foo\bar.py[c] | ||
| # <frozen foo> | ||
| # Do not match files that have 'foo' as a substring, | ||
| # unless the user explicitly states '.*foo.*'. | ||
| ignore_files_or = "|".join(mod for mod in ignore_files) | ||
| fname_pattern = re.compile( | ||
| r".*[\\/](" + "|".join(mod for mod in ignore_files) + r")([\\/]|$)" | ||
| rf".*[\\/]({ignore_files_or})([\\/]|\.pyc?$|$)" | ||
| rf"|<frozen ({ignore_files_or})>$" | ||
|
Comment on lines
+3253
to
+3266
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| ) | ||
| else: | ||
| # stacklevel 0 or less - shows dask internals which likely isn't helpful | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -304,7 +304,8 @@ def to_yamls( | |
| import yaml | ||
|
|
||
| root_dir = Path(root_dir) if root_dir else Path.cwd() | ||
| dumper = yaml.CSafeDumper | ||
| # libyaml C bindings may be missing | ||
| dumper = getattr(yaml, "CSafeDumper", yaml.SafeDumper) | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. They are missing in conda-forge for 3.14: conda-forge/pyyaml-feedstock#59 |
||
| scheduler_expand_keys = set(scheduler_expand_keys) | ||
| worker_expand_keys = set(worker_expand_keys) | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is identical to environment-3.13.yml, save for this line