Change extra_volumes to Optional in get_model_env #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utils/env.py:963 在 QTDockerEnv.prepare() 里执行 next(iter(self.conf.extra_volumes.keys()))，但 self.conf.extra_volumes 是空字典，抛出 StopIteration。
原因是这里把默认值覆盖掉了：
- components/coder/model_coder/conf.py:27 get_model_env() 的参数 extra_volumes 默认是 {}，然后无条件执行 env.conf.extra_volumes = extra_volumes.copy()，这会把 utils/env.py 里
QlibDockerConf 的默认 extra_volumes 覆盖成空。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
utils/env.py:963 在 QTDockerEnv.prepare() 里执行 next(iter(self.conf.extra_volumes.keys()))，但 self.conf.extra_volumes 是空字典，抛出 StopIteration。
原因是这里把默认值覆盖掉了：
Description
Motivation and Context
How Has This Been Tested?
Screenshots of Test Results (if appropriate):
Types of changes