🤖 fix: Runtime.ensureDir for Windows-safe temp dirs #1606
Conversation
Centralize mkdir -p semantics behind Runtime.ensureDir() so local runtimes use Node fs (Windows-safe) while remote runtimes keep POSIX shells. Use it for stream temp dirs and other local-risk callsites (MCP overrides, background process outputs). --- _Generated with `mux` • Model: `openai:gpt-5.2` • Thinking: `xhigh` • Cost: `$6.15`_
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8735f1d6b3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review Updated
|
|
Codex Review: Didn't find any major issues. Another round soon, please! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Fixes Windows workspace startup failures caused by shelling out to
mkdir -pon local runtimes.Changes:
Runtime.ensureDir()(local: Nodefs.mkdir({ recursive: true }); remote:mkdir -p)StreamManager.createTempDirForStream()touchwithwriteFileString)ensureDir+createTempDirForStreamValidation:
make static-checkGenerated with
mux• Model:openai:gpt-5.2• Thinking:xhigh• Cost:$6.15