🤖 fix: use destroy() for splash screen to avoid WebContents race #1540
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the splash screen closes via close(), Electron's internal sandboxed renderer scripts may still be executing. These scripts can try to access webContents properties after destruction, causing: - BROWSER_GET_LAST_WEB_PREFERENCES: WebContents does not exist - sandboxed_renderer.bundle.js script failed to run - TypeError: object null is not iterable Using destroy() immediately destroys the window without waiting for internal scripts to complete. This is appropriate for the splash since it has no state to preserve and no close handlers that need to run. Also adds isDestroyed() guard in notify.ts for notification click handlers that could fire after window destruction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the splash screen closes via
close(), Electron's internal sandboxed renderer scripts may still be executing. These scripts try to accesswebContentsproperties after destruction, causing:Fix: Use
destroy()instead ofclose()for immediate window destruction without waiting for internal scripts. This is appropriate since the splash has no state to preserve.Also adds
isDestroyed()guard innotify.tsfor notification click handlers.Generated with
mux• Model:mux-gateway:anthropic/claude-opus-4-5• Thinking:high• Cost:$2.42