Skip to content

Fix: Blocks shifts by the border's size when removed or debug mode enabled #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
canalun merged 3 commits into from
Jul 23, 2024
Merged

Fix: Blocks shifts by the border's size when removed or debug mode enabled #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
abdbcb0
Fix: Blocks shifts by border when removed or debug mode enabled
igrep Jun 22, 2024
0c8c4c1
Highlight with border when the elemen has border
igrep Jul 23, 2024
1a975d1
Small style fix
igrep Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/game/animation/updateBlocks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,11 @@ function removeBlockAndUpdateBlocksPosition(block: Block, blocks: Block[]) {
// make to-be-removed element red just a moment before removing it
const element = block.element as HTMLElement // TODO: remove type assertion
const originalBorderWidth = getComputedStyleWithCache(element).borderWidth
element.style.border = `${originalBorderWidth === "0px" ? "1px" : originalBorderWidth} solid red`
if (originalBorderWidth === "0px") {
element.style.outline = "1px solid red"
} else {
element.style.border = `${originalBorderWidth} solid red`
}

setTimeout(() => {
removeBlock(block)
Expand Down
4 changes: 2 additions & 2 deletions src/game/debug.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,12 @@ export function visualizeBlocks(blocks: Block[]) {
if (blocks[i].remain) {
;(blockElement as HTMLElement).style && // TODO: remove type assertion
Object.assign((blockElement as HTMLElement).style, {
border: "0.1px solid red"
outline: "0.1px solid red"
})
} else {
;(blockElement as HTMLElement).style && // TODO: remove type assertion
Object.assign((blockElement as HTMLElement).style, {
border: "none"
outline: "none"
})
}
}
Expand Down