Removing loop.exec() from bluetooth write mechanism to avoid ios crashes #4050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit eliminates QEventLoop::exec() calls in Bluetooth write operations for domyostreadmill and wahookickrsnapbike devices, which were causing crashes on iOS due to nested event loop incompatibilities. Changes: - Replaced synchronous loop.exec() with async queue-based system - Implemented WriteRequest queue with processWriteQueue() method - Added timeout management with QTimer for async operations - Updated characteristicWritten/packetReceived handlers for queue processing - Removed all #ifdef Q_OS_IOS conditionals in wahookickrsnapbike - Unified Bluetooth handling code across all platforms using pure Qt The new architecture: 1. writeCharacteristic() enqueues write requests instead of blocking 2. processWriteQueue() handles requests sequentially 3. Completion signals (characteristicWritten/packetReceived) trigger next item 4. Timeout handling prevents queue stalls without blocking main thread This eliminates the problematic pattern of calling loop.exec() from within the main event loop, which was causing watchdog timeouts and crashes on iOS. The solution is cross-platform compatible and improves responsiveness on all platforms. Fixes iOS crash issues related to nested event loops in Bluetooth operations.
Owner
Author
|
reference: ssssgibbs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit eliminates QEventLoop::exec() calls in Bluetooth write operations for domyostreadmill and wahookickrsnapbike devices, which were causing crashes on iOS due to nested event loop incompatibilities.
Changes:
The new architecture:
This eliminates the problematic pattern of calling loop.exec() from within the main event loop, which was causing watchdog timeouts and crashes on iOS. The solution is cross-platform compatible and improves responsiveness on all platforms.
Fixes iOS crash issues related to nested event loops in Bluetooth operations.