refactor(tarko-agent-cli): simplify setup ui logic #1631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for agent-tars-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for tarko ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| if (fs.existsSync(filePath)) { | ||
| return res.sendFile(filePath); | ||
| } | ||
| return fs.existsSync(filePath) ? res.sendFile(filePath) : next(); |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
| if (fs.existsSync(filePath)) { | ||
| return res.sendFile(filePath); | ||
| } | ||
| return fs.existsSync(filePath) ? res.sendFile(filePath) : next(); |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression High
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactored the
setupUIfunction in@tarko/agent-clito improve code clarity and maintainability. This change extracts complex routing logic into smaller, focused functions and simplifies the request handling flow.Key improvements:
injectConfigfunctionserveIndexWithConfigfunction for serving SPA routesmergedWebUIConfig.baseinstead ofwebui.basefor consistencyNo breaking changes - this is a pure refactor that maintains identical functionality.
Checklist