Skip to content

Conversation

@MartinKurtz
Copy link

Hi, this is related to #9254, and should implement the most basic version of "the easy option" outlined there.

It implements a warning about symlinks pointing outside of the backup mountpoint when using borg mount and adds it to the borg mount documentation as well as logs such a warning on a mount call.

I will mark this as a draft as i see this more as a preliminary suggestion.

Copy link
Member

@ThomasWaldmann ThomasWaldmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Good idea to have this as an easy/quick fix until we might have something better.

@MartinKurtz MartinKurtz marked this pull request as ready for review January 11, 2026 22:30
@MartinKurtz
Copy link
Author

I think i am happy with the wordings now

@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.57%. Comparing base (4eed3ec) to head (2da7c91).
⚠️ Report is 2 commits behind head on 1.4-maint.

Additional details and impacted files
@@              Coverage Diff              @@
##           1.4-maint    #9255      +/-   ##
=============================================
- Coverage      80.59%   80.57%   -0.02%     
=============================================
  Files             38       38              
  Lines          11256    11256              
  Branches        1771     1771              
=============================================
- Hits            9072     9070       -2     
- Misses          1615     1616       +1     
- Partials         569      570       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ThomasWaldmann ThomasWaldmann merged commit f379420 into borgbackup:1.4-maint Jan 12, 2026
20 of 22 checks passed
@ThomasWaldmann
Copy link
Member

Thanks!

Can you do a port to master branch?

@MartinKurtz
Copy link
Author

does that mean a second PR to the master branch with the same change? or is that some special git feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants