feat(js_analyze): implement noDivRegex #8757

Netail · 2026-01-12T23:15:35Z

Summary

Port Eslint's no-div-regex which disallows the equal signs explicitly at the beginning of regular expressions.

Closes #8738

Test Plan

Unit tests

Docs

https://eslint.org/docs/latest/rules/no-div-regex

changeset-bot · 2026-01-12T23:15:39Z

🦋 Changeset detected

Latest commit: 085c733

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages

Name	Type
@biomejs/biome	Patch
@biomejs/cli-win32-x64	Patch
@biomejs/cli-win32-arm64	Patch
@biomejs/cli-darwin-x64	Patch
@biomejs/cli-darwin-arm64	Patch
@biomejs/cli-linux-x64	Patch
@biomejs/cli-linux-arm64	Patch
@biomejs/cli-linux-x64-musl	Patch
@biomejs/cli-linux-arm64-musl	Patch
@biomejs/wasm-web	Patch
@biomejs/wasm-bundler	Patch
@biomejs/wasm-nodejs	Patch
@biomejs/backend-jsonrpc	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-01-12T23:19:10Z

Walkthrough

Adds a new nursery lint rule noDivRegex that detects regex literals beginning with =/ (e.g. /=foo/) and reports a diagnostic. Implements the rule, a safe automatic fix that rewrites /=.../ to /[=].../, and exposes NoDivRegex and its options type. Adds public NoDivRegexOptions and module export, plus unit tests (valid and invalid cases) exercising the rule.

Suggested reviewers

dyc3
ematipico

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The PR title accurately summarises the main change—implementing the noDivRegex linter rule. It's clear, concise, and directly reflects the changeset.
Description check	✅ Passed	The description properly explains the change: porting ESLint's no-div-regex rule to disallow equal signs at regex start, references the linked issue, mentions tests, and cites documentation.
Linked Issues check	✅ Passed	The PR fully implements the requested noDivRegex rule from issue #8738, including the rule implementation, options struct, test cases (valid and invalid), and integration into the codebase.
Out of Scope Changes check	✅ Passed	All changes directly support the noDivRegex implementation—rule logic, options, tests, module exports, and changelog entry. No extraneous modifications detected.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In @crates/biome_js_analyze/src/lint/nursery/no_div_regex.rs:
- Line 6: The replacement token is being created with ident(new_text.as_str()),
which yields a SyntaxKind::IDENT instead of a JS regex literal; replace that
call with constructing a detached regex token via
JsSyntaxToken::new_detached(JsSyntaxKind::JS_REGEX_LITERAL, new_text.as_str(),
[], []) so the replacement is the correct token kind (follow the pattern used in
use_regex_literals.rs and no_misleading_character_class.rs) and ensure you use
the existing new_text variable for the token text.

🧹 Nitpick comments (2)

crates/biome_rule_options/src/lib.rs (1)

429-429: Module export is out of alphabetical order.

The file header indicates this is generated by xtask/codegen. If you've manually added this line, it should be placed between no_distracting_elements and no_document_cookie to maintain alphabetical order. Alternatively, re-run codegen to ensure proper placement.
crates/biome_rule_options/src/no_div_regex.rs (1)
1-6: Consider adding rustdoc documentation.

The struct follows all the required conventions nicely. Per the coding guidelines, rule options should have inline rustdoc documentation. Even for an empty options struct, a brief comment helps maintain consistency.
📝 Suggested documentation
 use biome_deserialize_macros::{Deserializable, Merge};
 use serde::{Deserialize, Serialize};
+
+/// Options for the `noDivRegex` rule.
 #[derive(Default, Clone, Debug, Deserialize, Deserializable, Merge, Eq, PartialEq, Serialize)]
 #[cfg_attr(feature = "schema", derive(schemars::JsonSchema))]
 #[serde(rename_all = "camelCase", deny_unknown_fields, default)]
 pub struct NoDivRegexOptions {}

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f244526 and edcf3d4.

⛔ Files ignored due to path filters (4)

crates/biome_diagnostics_categories/src/categories.rs is excluded by !**/categories.rs and included by **
crates/biome_js_analyze/src/lint/nursery.rs is excluded by !**/nursery.rs and included by **
crates/biome_js_analyze/tests/specs/nursery/noDivRegex/invalid.js.snap is excluded by !**/*.snap and included by **
crates/biome_js_analyze/tests/specs/nursery/noDivRegex/valid.js.snap is excluded by !**/*.snap and included by **

📒 Files selected for processing (6)

.changeset/fast-needles-hammer.md
crates/biome_js_analyze/src/lint/nursery/no_div_regex.rs
crates/biome_js_analyze/tests/specs/nursery/noDivRegex/invalid.js
crates/biome_js_analyze/tests/specs/nursery/noDivRegex/valid.js
crates/biome_rule_options/src/lib.rs
crates/biome_rule_options/src/no_div_regex.rs

🧰 Additional context used

📓 Path-based instructions (1)

**/*.rs

📄 CodeRabbit inference engine (CONTRIBUTING.md)

**/*.rs: Use inline rustdoc documentation for rules, assists, and their options
Use the dbg!() macro for debugging output in Rust tests and code
Use doc tests (doctest) format with code blocks in rustdoc comments; ensure assertions pass in tests

Files:

crates/biome_rule_options/src/lib.rs
crates/biome_rule_options/src/no_div_regex.rs
crates/biome_js_analyze/src/lint/nursery/no_div_regex.rs

🧠 Learnings (25)

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/biome_rule_options/lib/**/*.rs : Rule options must be defined in the `biome_rule_options` crate with a file named after the rule

Applied to files:

crates/biome_rule_options/src/lib.rs
crates/biome_rule_options/src/no_div_regex.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/biome_rule_options/lib/**/*.rs : Use `Option<_>` wrapper for rule option fields to enable proper merging of configurations

Applied to files:

crates/biome_rule_options/src/lib.rs
crates/biome_rule_options/src/no_div_regex.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/biome_rule_options/lib/**/*.rs : Rule option types must derive `Deserializable`, `Serialize`, `Deserialize`, and optionally `JsonSchema` traits

Applied to files:

crates/biome_rule_options/src/lib.rs
crates/biome_rule_options/src/no_div_regex.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/biome_rule_options/lib/**/*.rs : Apply `#[serde(rename_all = "camelCase")]` to rule option structs to match JSON configuration naming convention

Applied to files:

crates/biome_rule_options/src/lib.rs
crates/biome_rule_options/src/no_div_regex.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/biome_rule_options/lib/**/*.rs : Apply `#[serde(deny_unknown_fields)]` to rule option structs to enforce strict configuration validation

Applied to files:

crates/biome_rule_options/src/lib.rs
crates/biome_rule_options/src/no_div_regex.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/biome_rule_options/lib/**/*.rs : Implement `biome_deserialize::Merge` for rule option types to define how shared and user configurations are merged

Applied to files:

crates/biome_rule_options/src/lib.rs
crates/biome_rule_options/src/no_div_regex.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/biome_rule_options/lib/**/*.rs : Use `Box<[Box<str>]>` instead of `Vec<String>` for collections of strings in rule options to save memory

Applied to files:

crates/biome_rule_options/src/lib.rs

📚 Learning: 2025-11-24T18:06:03.545Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_parser/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:06:03.545Z
Learning: Applies to crates/biome_parser/**/language_kind.rs : Add a new language prefix to the `LANGUAGE_PREFIXES` constant in `language_kind.rs` file

Applied to files:

crates/biome_rule_options/src/lib.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Rule names should use the `no` prefix when the rule's sole intention is to forbid a single concept

Applied to files:

crates/biome_rule_options/src/lib.rs
crates/biome_js_analyze/src/lint/nursery/no_div_regex.rs

📚 Learning: 2025-11-24T18:06:03.545Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_parser/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:06:03.545Z
Learning: Applies to crates/biome_parser/**/src/**/*.rs : Parse rule functions must be prefixed with `parse_` and use the name defined in the grammar file, e.g., `parse_for_statement` or `parse_expression`

Applied to files:

crates/biome_rule_options/src/lib.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/tests/specs/**/* : Create test files with `invalid` and `valid` prefixes to represent code that should and should not trigger the rule

Applied to files:

crates/biome_js_analyze/tests/specs/nursery/noDivRegex/invalid.js
crates/biome_js_analyze/tests/specs/nursery/noDivRegex/valid.js

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Invalid code snippets in rule documentation must emit exactly one diagnostic

Applied to files:

crates/biome_js_analyze/tests/specs/nursery/noDivRegex/invalid.js
crates/biome_js_analyze/src/lint/nursery/no_div_regex.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/tests/specs/**/*.jsonc : Use `.jsonc` format for test files containing multiple code snippets, where each snippet is a string in an array

Applied to files:

crates/biome_js_analyze/tests/specs/nursery/noDivRegex/invalid.js
crates/biome_js_analyze/tests/specs/nursery/noDivRegex/valid.js

📚 Learning: 2025-12-04T13:29:49.287Z

Learnt from: dyc3
Repo: biomejs/biome PR: 8291
File: crates/biome_html_formatter/tests/specs/prettier/vue/html-vue/elastic-header.html:10-10
Timestamp: 2025-12-04T13:29:49.287Z
Learning: Files under `crates/biome_html_formatter/tests/specs/prettier` are test fixtures synced from Prettier and should not receive detailed code quality reviews (e.g., HTTP vs HTTPS, formatting suggestions, etc.). These files are test data meant to validate formatter behavior and should be preserved as-is.

Applied to files:

crates/biome_js_analyze/tests/specs/nursery/noDivRegex/invalid.js
crates/biome_js_analyze/tests/specs/nursery/noDivRegex/valid.js

📚 Learning: 2025-11-21T01:10:53.059Z

Learnt from: dyc3
Repo: biomejs/biome PR: 8171
File: crates/biome_js_analyze/src/lint/nursery/no_leaked_render.rs:125-137
Timestamp: 2025-11-21T01:10:53.059Z
Learning: In the Biome codebase, each lint rule has its own options type declaration (e.g., `type Options = RuleNameOptions`) as part of the codegen process, even if the options struct is empty or unused. This is standard practice and should not be flagged as an issue.

Applied to files:

crates/biome_rule_options/src/no_div_regex.rs

📚 Learning: 2025-12-22T09:26:56.943Z

Learnt from: ematipico
Repo: biomejs/biome PR: 8537
File: crates/biome_js_analyze/src/lint/nursery/no_leaked_render.rs:167-210
Timestamp: 2025-12-22T09:26:56.943Z
Learning: When defining lint rules (declare_lint_rule!), only specify fix_kind if the rule implements an action(...) function. Rules that only emit diagnostics without a code fix should omit fix_kind. This applies to all Rust lint rule definitions under crates/.../src/lint (e.g., crates/biome_js_analyze/src/lint/...).

Applied to files:

crates/biome_js_analyze/src/lint/nursery/no_div_regex.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Use `rule_category!()` macro to refer to the diagnostic category instead of dynamically parsing its string name

Applied to files:

crates/biome_js_analyze/src/lint/nursery/no_div_regex.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Deprecated rules must include a `deprecated` field in the `declare_lint_rule!` macro with an explanation of what rule to use instead

Applied to files:

crates/biome_js_analyze/src/lint/nursery/no_div_regex.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Use `declare_lint_rule!` macro with a `version` field set to `next` for new rules

Applied to files:

crates/biome_js_analyze/src/lint/nursery/no_div_regex.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : New rules must be placed inside the `nursery` group before promotion to other groups

Applied to files:

crates/biome_js_analyze/src/lint/nursery/no_div_regex.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Code blocks in rule documentation must specify a language identifier and be tagged with `expect_diagnostic` for invalid examples or remain untagged for valid examples

Applied to files:

crates/biome_js_analyze/src/lint/nursery/no_div_regex.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Mark rules with `issue_number` in the `declare_lint_rule!` macro if they are work-in-progress to indicate missing features

Applied to files:

crates/biome_js_analyze/src/lint/nursery/no_div_regex.rs

📚 Learning: 2025-12-31T15:35:32.899Z

Learnt from: dyc3
Repo: biomejs/biome PR: 8639
File: crates/biome_js_analyze/src/lint/nursery/no_excessive_lines_per_file.rs:101-108
Timestamp: 2025-12-31T15:35:32.899Z
Learning: In Rust lint rules under the nursery category, the issue_number field in declare_lint_rule! is optional and should not be added unless there is a compelling reason. In code reviews, verify that no unnecessary issue_number is included in nursery lint declarations. Only add issue_number if there is an explicit, justified reason (e.g., tracked issue for external observers). This guidance broadly applies to all nursery lint rule files, not just the single file.

Applied to files:

crates/biome_js_analyze/src/lint/nursery/no_div_regex.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : When porting rules from other linters, use `sources` metadata with `RuleSource::Eslint().same()` for identical behavior or `.inspired()` for different behavior

Applied to files:

crates/biome_js_analyze/src/lint/nursery/no_div_regex.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Rule names should use the `use` prefix when the rule's sole intention is to mandate a single concept

Applied to files:

crates/biome_js_analyze/src/lint/nursery/no_div_regex.rs

🧬 Code graph analysis (1)

crates/biome_js_analyze/src/lint/nursery/no_div_regex.rs (1)

crates/biome_analyze/src/rule.rs (3)

recommended (625-628)

sources (640-643)

same (255-260)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (12)

GitHub Check: Test (depot-ubuntu-24.04-arm-16)
GitHub Check: Documentation
GitHub Check: Test (depot-windows-2022-16)
GitHub Check: Test Node.js API
GitHub Check: Lint project (depot-ubuntu-24.04-arm-16)
GitHub Check: End-to-end tests
GitHub Check: Check Dependencies
GitHub Check: Lint project (depot-windows-2022)
GitHub Check: autofix
GitHub Check: Bench (biome_js_analyze)
GitHub Check: Bench (biome_js_parser)
GitHub Check: Bench (biome_js_formatter)

🔇 Additional comments (6)

crates/biome_js_analyze/tests/specs/nursery/noDivRegex/invalid.js (1)

1-2: LGTM!

The test case correctly exercises the rule with a regex starting with =/. Consider adding more edge cases in future iterations, such as /==foo/ or /=$/, to ensure comprehensive coverage.

.changeset/fast-needles-hammer.md (1)

1-13: LGTM!

The changeset entry is clear and provides a helpful example of the invalid pattern. The documentation link is properly formatted.

crates/biome_js_analyze/tests/specs/nursery/noDivRegex/valid.js (1)

1-4: LGTM!

Good coverage of valid cases: a standard regex and one with an escaped equals sign. The latter correctly ensures the rule doesn't flag \= as problematic.

crates/biome_js_analyze/src/lint/nursery/no_div_regex.rs (3)

13-44: LGTM on the rule declaration!

Documentation is clear, uses expect_diagnostic for the invalid example, and the metadata is correctly set: version: "next" for new rules, .same() for porting ESLint behaviour, and fix_kind specified since action() is implemented. Based on learnings, this follows the conventions nicely.

53-66: Detection logic looks sound.

Checking text.chars().nth(1) correctly identifies the character after the opening /. For /=foo/, index 1 is indeed =.

68-82: Diagnostic is clear and helpful.

The message explains the confusion with /= and the note provides actionable guidance. Well done.

crates/biome_js_analyze/src/lint/nursery/no_div_regex.rs

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

crates/biome_js_analyze/src/lint/nursery/no_div_regex.rs (1)
90-95: Consider preserving original token trivia.

The new token is created with empty trivia arrays, which discards any leading/trailing whitespace or comments from the original token. In practice this rarely matters for regex literals, but for a robust safe fix, consider preserving the original trivia:
💡 Optional improvement to preserve trivia
+        let original_token = node.value_token().ok()?;
         let new_node = node.clone().with_value_token(JsSyntaxToken::new_detached(
             JsSyntaxKind::JS_REGEX_LITERAL,
             new_text.as_str(),
-            [],
-            [],
+            original_token.leading_trivia().pieces(),
+            original_token.trailing_trivia().pieces(),
         ));

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between edcf3d4 and 085c733.

⛔ Files ignored due to path filters (8)

crates/biome_cli/src/execute/migrate/eslint_any_rule_to_biome.rs is excluded by !**/migrate/eslint_any_rule_to_biome.rs and included by **
crates/biome_configuration/src/analyzer/linter/rules.rs is excluded by !**/rules.rs and included by **
crates/biome_diagnostics_categories/src/categories.rs is excluded by !**/categories.rs and included by **
crates/biome_js_analyze/src/lint/nursery.rs is excluded by !**/nursery.rs and included by **
crates/biome_js_analyze/tests/specs/nursery/noDivRegex/invalid.js.snap is excluded by !**/*.snap and included by **
crates/biome_js_analyze/tests/specs/nursery/noDivRegex/valid.js.snap is excluded by !**/*.snap and included by **
packages/@biomejs/backend-jsonrpc/src/workspace.ts is excluded by !**/backend-jsonrpc/src/workspace.ts and included by **
packages/@biomejs/biome/configuration_schema.json is excluded by !**/configuration_schema.json and included by **

📒 Files selected for processing (6)

.changeset/fast-needles-hammer.md
crates/biome_js_analyze/src/lint/nursery/no_div_regex.rs
crates/biome_js_analyze/tests/specs/nursery/noDivRegex/invalid.js
crates/biome_js_analyze/tests/specs/nursery/noDivRegex/valid.js
crates/biome_rule_options/src/lib.rs
crates/biome_rule_options/src/no_div_regex.rs

🚧 Files skipped from review as they are similar to previous changes (4)

crates/biome_js_analyze/tests/specs/nursery/noDivRegex/valid.js
crates/biome_rule_options/src/lib.rs
.changeset/fast-needles-hammer.md
crates/biome_js_analyze/tests/specs/nursery/noDivRegex/invalid.js

🧰 Additional context used

📓 Path-based instructions (1)

**/*.rs

📄 CodeRabbit inference engine (CONTRIBUTING.md)

**/*.rs: Use inline rustdoc documentation for rules, assists, and their options
Use the dbg!() macro for debugging output in Rust tests and code
Use doc tests (doctest) format with code blocks in rustdoc comments; ensure assertions pass in tests

Files:

crates/biome_rule_options/src/no_div_regex.rs
crates/biome_js_analyze/src/lint/nursery/no_div_regex.rs

🧠 Learnings (23)

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/biome_rule_options/lib/**/*.rs : Rule option types must derive `Deserializable`, `Serialize`, `Deserialize`, and optionally `JsonSchema` traits

Applied to files:

crates/biome_rule_options/src/no_div_regex.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/biome_rule_options/lib/**/*.rs : Apply `#[serde(deny_unknown_fields)]` to rule option structs to enforce strict configuration validation

Applied to files:

crates/biome_rule_options/src/no_div_regex.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/biome_rule_options/lib/**/*.rs : Apply `#[serde(rename_all = "camelCase")]` to rule option structs to match JSON configuration naming convention

Applied to files:

crates/biome_rule_options/src/no_div_regex.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/biome_rule_options/lib/**/*.rs : Use `Option<_>` wrapper for rule option fields to enable proper merging of configurations

Applied to files:

crates/biome_rule_options/src/no_div_regex.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/biome_rule_options/lib/**/*.rs : Implement `biome_deserialize::Merge` for rule option types to define how shared and user configurations are merged

Applied to files:

crates/biome_rule_options/src/no_div_regex.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/biome_rule_options/lib/**/*.rs : Rule options must be defined in the `biome_rule_options` crate with a file named after the rule

Applied to files:

crates/biome_rule_options/src/no_div_regex.rs

📚 Learning: 2025-11-21T01:10:53.059Z

Learnt from: dyc3
Repo: biomejs/biome PR: 8171
File: crates/biome_js_analyze/src/lint/nursery/no_leaked_render.rs:125-137
Timestamp: 2025-11-21T01:10:53.059Z
Learning: In the Biome codebase, each lint rule has its own options type declaration (e.g., `type Options = RuleNameOptions`) as part of the codegen process, even if the options struct is empty or unused. This is standard practice and should not be flagged as an issue.

Applied to files:

crates/biome_rule_options/src/no_div_regex.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Rule names should use the `no` prefix when the rule's sole intention is to forbid a single concept

Applied to files:

crates/biome_rule_options/src/no_div_regex.rs
crates/biome_js_analyze/src/lint/nursery/no_div_regex.rs

📚 Learning: 2025-12-22T09:26:56.943Z

Learnt from: ematipico
Repo: biomejs/biome PR: 8537
File: crates/biome_js_analyze/src/lint/nursery/no_leaked_render.rs:167-210
Timestamp: 2025-12-22T09:26:56.943Z
Learning: When defining lint rules (declare_lint_rule!), only specify fix_kind if the rule implements an action(...) function. Rules that only emit diagnostics without a code fix should omit fix_kind. This applies to all Rust lint rule definitions under crates/.../src/lint (e.g., crates/biome_js_analyze/src/lint/...).

Applied to files:

crates/biome_js_analyze/src/lint/nursery/no_div_regex.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Invalid code snippets in rule documentation must emit exactly one diagnostic

Applied to files:

crates/biome_js_analyze/src/lint/nursery/no_div_regex.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Deprecated rules must include a `deprecated` field in the `declare_lint_rule!` macro with an explanation of what rule to use instead

Applied to files:

crates/biome_js_analyze/src/lint/nursery/no_div_regex.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Use `declare_lint_rule!` macro with a `version` field set to `next` for new rules

Applied to files:

crates/biome_js_analyze/src/lint/nursery/no_div_regex.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : New rules must be placed inside the `nursery` group before promotion to other groups

Applied to files:

crates/biome_js_analyze/src/lint/nursery/no_div_regex.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Use `rule_category!()` macro to refer to the diagnostic category instead of dynamically parsing its string name

Applied to files:

crates/biome_js_analyze/src/lint/nursery/no_div_regex.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Implement the `action` function and add `fix_kind` metadata to the rule macro if the rule provides code actions

Applied to files:

crates/biome_js_analyze/src/lint/nursery/no_div_regex.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : The first paragraph of rule documentation must be written in a single line to ensure proper rendering in the rules overview table

Applied to files:

crates/biome_js_analyze/src/lint/nursery/no_div_regex.rs

📚 Learning: 2025-12-31T15:35:32.899Z

Learnt from: dyc3
Repo: biomejs/biome PR: 8639
File: crates/biome_js_analyze/src/lint/nursery/no_excessive_lines_per_file.rs:101-108
Timestamp: 2025-12-31T15:35:32.899Z
Learning: In Rust lint rules under the nursery category, the issue_number field in declare_lint_rule! is optional and should not be added unless there is a compelling reason. In code reviews, verify that no unnecessary issue_number is included in nursery lint declarations. Only add issue_number if there is an explicit, justified reason (e.g., tracked issue for external observers). This guidance broadly applies to all nursery lint rule files, not just the single file.

Applied to files:

crates/biome_js_analyze/src/lint/nursery/no_div_regex.rs

📚 Learning: 2025-10-03T12:28:56.788Z

Learnt from: ematipico
Repo: biomejs/biome PR: 7670
File: crates/biome_service/src/file_handlers/html.rs:744-748
Timestamp: 2025-10-03T12:28:56.788Z
Learning: In Biome's codebase, when creating tokens with new text content, use the factory pattern with functions like `ident(text)` from the respective `*_factory` crates (e.g., `biome_html_factory::make::ident`). There is no `.with_text()` method on tokens. The `ident()` function creates a new detached token with the IDENT kind, which is the standard approach for token construction.

Applied to files:

crates/biome_js_analyze/src/lint/nursery/no_div_regex.rs

📚 Learning: 2025-11-24T18:05:27.810Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_js_formatter/CONTRIBUTING.md:0-0
Timestamp: 2025-11-24T18:05:27.810Z
Learning: Applies to crates/biome_js_formatter/**/*.rs : When formatting AST nodes, use mandatory tokens from the AST instead of hardcoding token strings (e.g., use `node.l_paren_token().format()` instead of `token("(")`)

Applied to files:

crates/biome_js_analyze/src/lint/nursery/no_div_regex.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Avoid string allocations by using `&str` or `TokenText` instead of `to_string()`

Applied to files:

crates/biome_js_analyze/src/lint/nursery/no_div_regex.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Code blocks in rule documentation must specify a language identifier and be tagged with `expect_diagnostic` for invalid examples or remain untagged for valid examples

Applied to files:

crates/biome_js_analyze/src/lint/nursery/no_div_regex.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : Rule names should use the `use` prefix when the rule's sole intention is to mandate a single concept

Applied to files:

crates/biome_js_analyze/src/lint/nursery/no_div_regex.rs

📚 Learning: 2026-01-02T14:58:16.536Z

Learnt from: CR
Repo: biomejs/biome PR: 0
File: crates/biome_analyze/CONTRIBUTING.md:0-0
Timestamp: 2026-01-02T14:58:16.536Z
Learning: Applies to crates/biome_analyze/**/*_analyze/**/src/lint/**/*.rs : When porting rules from other linters, use `sources` metadata with `RuleSource::Eslint().same()` for identical behavior or `.inspired()` for different behavior

Applied to files:

crates/biome_js_analyze/src/lint/nursery/no_div_regex.rs

🧬 Code graph analysis (1)

crates/biome_js_analyze/src/lint/nursery/no_div_regex.rs (2)

crates/biome_analyze/src/rule.rs (3)

recommended (625-628)

sources (640-643)

same (255-260)

crates/biome_rowan/src/syntax/node.rs (1)

new_detached (33-47)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (14)

GitHub Check: Lint project (depot-ubuntu-24.04-arm-16)
GitHub Check: End-to-end tests
GitHub Check: Test (depot-windows-2022-16)
GitHub Check: Test (depot-ubuntu-24.04-arm-16)
GitHub Check: Lint project (depot-windows-2022)
GitHub Check: Check Dependencies
GitHub Check: Documentation
GitHub Check: Test Node.js API
GitHub Check: Check JS Files
GitHub Check: Bench (biome_js_parser)
GitHub Check: Bench (biome_js_analyze)
GitHub Check: Bench (biome_js_formatter)
GitHub Check: autofix
GitHub Check: Bench (biome_configuration)

🔇 Additional comments (4)

crates/biome_rule_options/src/no_div_regex.rs (1)

1-6: LGTM!

Options struct correctly derives all required traits per the crate conventions. Empty struct is appropriate for a rule without configurable options. Based on learnings, all necessary derives and serde attributes are present.

crates/biome_js_analyze/src/lint/nursery/no_div_regex.rs (3)

12-44: Well-documented rule declaration.

Correctly uses version: "next", proper ESLint source attribution with .same(), and documentation follows all conventions. The fix_kind: FixKind::Safe is appropriate since the transformation is semantically equivalent.

52-65: LGTM!

Detection logic is correct. Checking text.chars().nth(1) == '=' properly identifies regex literals starting with /= whilst safely handling short/edge-case inputs.

67-81: LGTM!

Clear diagnostic message with helpful note explaining the fix. Correctly uses rule_category!() macro.

codspeed-hq · 2026-01-12T23:28:39Z

Merging this PR will not alter performance

✅ 58 untouched benchmarks
⏩ 95 skipped benchmarks¹

_{Comparing Netail:feat/no-div-regex (085c733) with main (f244526)}

95 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

github-actions bot added A-Linter Area: linter L-JavaScript Language: JavaScript and super languages A-Diagnostic Area: diagnostocis labels Jan 12, 2026

coderabbitai bot reviewed Jan 12, 2026

View reviewed changes

crates/biome_js_analyze/src/lint/nursery/no_div_regex.rs Outdated Show resolved Hide resolved

github-actions bot added A-CLI Area: CLI A-Project Area: project labels Jan 12, 2026

feat(js_analyze): implement noDivRegex

085c733

Netail force-pushed the feat/no-div-regex branch from 07c6eab to 085c733 Compare January 12, 2026 23:22

coderabbitai bot reviewed Jan 12, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(js_analyze): implement noDivRegex #8757

feat(js_analyze): implement noDivRegex #8757

Netail commented Jan 12, 2026

Uh oh!

changeset-bot bot commented Jan 12, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Jan 12, 2026 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Uh oh!

codspeed-hq bot commented Jan 12, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

feat(js_analyze): implement noDivRegex #8757

Are you sure you want to change the base?

feat(js_analyze): implement noDivRegex #8757

Conversation

Netail commented Jan 12, 2026

Summary

Test Plan

Docs

Uh oh!

changeset-bot bot commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai bot commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Suggested reviewers

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

codspeed-hq bot commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

changeset-bot bot commented Jan 12, 2026 •

edited

Loading

coderabbitai bot commented Jan 12, 2026 •

edited

Loading

codspeed-hq bot commented Jan 12, 2026 •

edited

Loading