rockchip-rv1106: .config: manual fixes #8898

rpardini · 2025-11-09T13:05:50Z

rockchip-rv1106: .config: manual fixes

rockchip-rv1106: .config: fix =m set options that are bool manually
- =m is not a valid value for options that are bool
  - so change them to =y manually
- from olddefconfig:
  - .config:82:warning: symbol value 'm' invalid for BT_RFCOMM_TTY
  - .config:84:warning: symbol value 'm' invalid for BT_BNEP_MC_FILTER
  - .config:85:warning: symbol value 'm' invalid for BT_BNEP_PROTO_FILTER
  - .config:87:warning: symbol value 'm' invalid for BT_HS
  - .config:89:warning: symbol value 'm' invalid for BT_LEDS
  - .config:90:warning: symbol value 'm' invalid for BT_MSFTEXT
  - .config:92:warning: symbol value 'm' invalid for BT_HCIBTUSB_AUTOSUSPEND
  - .config:93:warning: symbol value 'm' invalid for BT_HCIBTUSB_MTK
  - .config:96:warning: symbol value 'm' invalid for BT_HCIUART_BCSP
  - .config:97:warning: symbol value 'm' invalid for BT_HCIUART_ATH3K
  - .config:99:warning: symbol value 'm' invalid for BT_HCIUART_BCM
  - .config:100:warning: symbol value 'm' invalid for BT_HCIUART_RTL
  - .config:101:warning: symbol value 'm' invalid for BT_HCIUART_QCA
  - .config:102:warning: symbol value 'm' invalid for BT_HCIUART_AG6XX
  - .config:250:warning: symbol value 'm' invalid for AIC_WLAN_SUPPORT
rockchip-rv1106: .config: remove a few WLAN_VENDOR =n's manually
- rockchip-rv1106: .config: remove WLAN_VENDOR_MEDIATEK =n manually
- rockchip-rv1106: .config: remove WLAN_VENDOR_RALINK =n manually
- rockchip-rv1106: .config: remove WLAN_VENDOR_MARVELL =n manually
- rockchip-rv1106: .config: remove WLAN_VENDOR_ATMEL =n manually
- rockchip-rv1106: .config: remove WLAN_VENDOR_ATH =n manually
- rockchip-rv1106: .config: remove WLAN_VENDOR_REALTEK =n manually
- those are hard dependencies for a bunch of wifi opts that are =m

Summary by CodeRabbit

Chores
- Kernel configuration optimized for Rockchip RV1106 device: Multiple Bluetooth connectivity features including various operation modes and protocols, combined with WiFi vendor driver support, are now permanently compiled into the kernel rather than loaded as dynamic modules. This optimization improves system startup performance, broadens supported hardware compatibility, and enhances overall wireless connectivity reliability.

- `=m` is not a valid value for options that are `bool` - so change them to `=y` manually - from olddefconfig: - `.config:82:warning: symbol value 'm' invalid for BT_RFCOMM_TTY` - `.config:84:warning: symbol value 'm' invalid for BT_BNEP_MC_FILTER` - `.config:85:warning: symbol value 'm' invalid for BT_BNEP_PROTO_FILTER` - `.config:87:warning: symbol value 'm' invalid for BT_HS` - `.config:89:warning: symbol value 'm' invalid for BT_LEDS` - `.config:90:warning: symbol value 'm' invalid for BT_MSFTEXT` - `.config:92:warning: symbol value 'm' invalid for BT_HCIBTUSB_AUTOSUSPEND` - `.config:93:warning: symbol value 'm' invalid for BT_HCIBTUSB_MTK` - `.config:96:warning: symbol value 'm' invalid for BT_HCIUART_BCSP` - `.config:97:warning: symbol value 'm' invalid for BT_HCIUART_ATH3K` - `.config:99:warning: symbol value 'm' invalid for BT_HCIUART_BCM` - `.config:100:warning: symbol value 'm' invalid for BT_HCIUART_RTL` - `.config:101:warning: symbol value 'm' invalid for BT_HCIUART_QCA` - `.config:102:warning: symbol value 'm' invalid for BT_HCIUART_AG6XX` - `.config:250:warning: symbol value 'm' invalid for AIC_WLAN_SUPPORT`

- rockchip-rv1106: .config: remove WLAN_VENDOR_MEDIATEK `=n` manually - rockchip-rv1106: .config: remove WLAN_VENDOR_RALINK `=n` manually - rockchip-rv1106: .config: remove WLAN_VENDOR_MARVELL `=n` manually - rockchip-rv1106: .config: remove WLAN_VENDOR_ATMEL `=n` manually - rockchip-rv1106: .config: remove WLAN_VENDOR_ATH `=n` manually - rockchip-rv1106: .config: remove WLAN_VENDOR_REALTEK `=n` manually - those are hard dependencies for a bunch of wifi opts that are `=m`

coderabbitai · 2025-11-09T13:06:04Z

Walkthrough

Kernel configuration for Rockchip RV1106 is updated: 14 Bluetooth-related options and one WLAN option are converted from modular (m) to built-in (y) form, and six commented-out WLAN vendor options are removed.

Changes

Cohort / File(s)	Change Summary
Bluetooth & WLAN kernel config consolidation `config/kernel/linux-rockchip-rv1106-vendor.config`	14 Bluetooth CONFIG options (CONFIG_BT_RFCOMM_TTY, CONFIG_BT_BNEP_MC_FILTER, CONFIG_BT_BNEP_PROTO_FILTER, CONFIG_BT_HS, CONFIG_BT_LEDS, CONFIG_BT_MSFTEXT, CONFIG_BT_HCIBTUSB_AUTOSUSPEND, CONFIG_BT_HCIBTUSB_MTK, CONFIG_BT_HCIUART_BCSP, CONFIG_BT_HCIUART_ATH3K, CONFIG_BT_HCIUART_BCM, CONFIG_BT_HCIUART_RTL, CONFIG_BT_HCIUART_QCA, CONFIG_BT_HCIUART_AG6XX) and 1 WLAN option (CONFIG_AIC_WLAN_SUPPORT) converted from modular to built-in; 6 commented-out WLAN vendor options removed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Simple, repetitive configuration value changes (m → y)
Single file with straightforward modifications
No logic or control flow changes
Review should verify option validity and correctness for the target hardware

Possibly related PRs

family: rockchip: add rv1103/rv1106 + first board 'LuckFox Pico Mini' #8797 — Adds initial vendor config for RV1106, which is the file being modified in this PR.
armbian-kernel: remove inconsistent conditionals #8820 — Implements unified handling for module vs built-in kernel options, directly relevant to this PR's pattern of converting options from m to y.

Suggested reviewers

igorpecovnik
paolosabatino
pyavitz

Poem

🐰 Bluetooth hops from module mode to built-in ground,
WiFi vendors quieted, comments all unbound—
One little config file, now cleaner and tight,
RV1106's kernel stack shines ever bright! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title "rockchip-rv1106: .config: manual fixes" accurately describes the main change—manual configuration fixes to a rockchip-rv1106 kernel config file.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 0bd81c9 and 3cda0a3.

📒 Files selected for processing (1)

config/kernel/linux-rockchip-rv1106-vendor.config (2 hunks)

🧰 Additional context used

🧠 Learnings (15)

📓 Common learnings

Learnt from: EvilOlaf
Repo: armbian/build PR: 8428
File: config/boards/lckfb-taishanpi.csc:5-9
Timestamp: 2025-07-25T03:51:50.830Z
Learning: When reviewing PRs in the Armbian build system, U-Boot defconfig files and patches may be added as part of the PR changes but might not be visible in the current repository clone state during review. It's important to check the actual PR file changes directly via GitHub or the PR API to get the complete picture of what files are being added or modified.

Learnt from: tabrisnet
Repo: armbian/build PR: 8661
File: lib/functions/compilation/armbian-kernel.sh:194-199
Timestamp: 2025-09-25T18:37:00.330Z
Learning: In PR armbian/build#8661, line 235 of lib/functions/compilation/armbian-kernel.sh already contains the corrected comment "BPF link support for netfilter hooks" for NETFILTER_BPF_LINK, not the misleading "BPF_SYSCALL" comment that was flagged during review.

Learnt from: tabrisnet
Repo: armbian/build PR: 8661
File: lib/functions/compilation/armbian-kernel.sh:194-199
Timestamp: 2025-09-25T18:37:00.330Z
Learning: In PR armbian/build#8661, line 235 of lib/functions/compilation/armbian-kernel.sh already contains the corrected comment "BPF link support for netfilter hooks" for NETFILTER_BPF_LINK, not the misleading "BPF_SYSCALL" comment that was flagged during review.

Learnt from: EvilOlaf
Repo: armbian/build PR: 8428
File: config/boards/lckfb-taishanpi.csc:5-9
Timestamp: 2025-07-25T03:51:50.830Z
Learning: When reviewing PRs in the Armbian build system, U-Boot defconfig files and patches may be added as part of the PR changes but might not be visible in the current repository clone state during review. It's important to check the actual PR file changes directly via GitHub API (https://api.github.com/repos/armbian/build/pulls/{pr_number}/files) to get the complete picture of what files are being added or modified, especially for U-Boot patches that will be applied during the build process.

Learnt from: rpardini
Repo: armbian/build PR: 8820
File: config/sources/families/include/meson64_common.inc:51-53
Timestamp: 2025-10-26T12:56:29.185Z
Learning: In the Armbian build framework, scripts/config correctly handles kernel configuration option names both with and without the CONFIG_ prefix, so opts_m+=("CONFIG_RTL8822CS") and opts_m+=("RTL8822CS") are both valid and will work correctly.

Learnt from: tabrisnet
Repo: armbian/build PR: 8678
File: config/kernel/linux-sunxi64-current.config:94-94
Timestamp: 2025-09-27T21:50:15.915Z
Learning: When kernel config files are generated through Armbian's automated process (previous config → armbian-kernel.sh changes → make oldconfig → Armbian machinery processing), manual config file edits are not appropriate since they would be overwritten. Deprecated option handling should be implemented in the automated tooling instead.

Learnt from: igorpecovnik
Repo: armbian/build PR: 8789
File: config/kernel/linux-sunxi64-edge.config:839-839
Timestamp: 2025-10-22T07:51:53.015Z
Learning: In Armbian's wireless driver configuration, CONFIG_RK_WIFI_DEVICE_* options are Rockchip-specific device registration settings, while CONFIG_WLAN_UWE* are the actual cross-platform driver modules for UWE5622 wireless chips. The UWE5622 chip (manufactured by Unisoc/Spreadtrum) is used on multiple Allwinner boards including Orange Pi Zero 2/2W/3 and Orange Pi 3 LTS, so CONFIG_WLAN_UWE5621/5622 along with Unisoc infrastructure options (CONFIG_SPARD_WLAN_SUPPORT, CONFIG_SC23XX, CONFIG_UNISOC_WIFI_PS, CONFIG_WCN_BSP_DRIVER_BUILDIN) are correct in sunxi64 kernel configs.

Learnt from: tabrisnet
Repo: armbian/build PR: 0
File: :0-0
Timestamp: 2025-08-30T04:13:16.457Z
Learning: Armbian kernel configuration files like linux-filogic-current.config are autogenerated overlays on top of arch defconfig. Comments added manually will be lost during future updates by maintainers, and explicit "CONFIG_OPTION is not set" statements aren't needed for mutually exclusive options since these are overlay configs that only specify changes from the base configuration.

Learnt from: igorpecovnik
Repo: armbian/build PR: 8849
File: config/boards/radxa-e54c.csc:14-28
Timestamp: 2025-11-02T20:49:56.719Z
Learning: In Armbian board configuration files (config/boards/*.conf, *.csc, etc.), do not use kernel_config_set, kernel_config_set_m, kernel_config_set_y, or custom_kernel_config__* functions to modify kernel configuration. Kernel configuration is associated with LINUXFAMILY/BOARDFAMILY, not individual BOARD. Board-specific kernel modifications cause inconsistency in kernel packages published to the apt repository because boards within a family share the same kernel packages. Kernel configuration changes must be made in the appropriate kernel config file (e.g., config/kernel/linux-*-*.config) or in family configuration files (config/sources/families/*.conf, *.inc) instead.

Learnt from: igorpecovnik
Repo: armbian/build PR: 8812
File: config/kernel/linux-sm8250-edge.config:498-501
Timestamp: 2025-10-23T19:48:42.980Z
Learning: For Armbian EDGE kernel configs, CONFIG_ATH12K=m alone is sufficient for PCI-based Wi-Fi 7 devices (e.g., WCN785x/QCN9274). A separate CONFIG_ATH12K_PCI option is not required, as confirmed by maintainer testing.

Learnt from: rafayahmed317
Repo: armbian/build PR: 8484
File: config/kernel/linux-rk35xx-vendor.config:904-906
Timestamp: 2025-08-11T22:00:13.411Z
Learning: In the linux-rk35xx-vendor kernel, the LTE driver options (CONFIG_LTE, CONFIG_LTE_RM310, CONFIG_LTE_EM05) are defined as boolean in drivers/net/lte/Kconfig and cannot be built as modules - they must be either built-in (=y) or disabled.

Learnt from: igorpecovnik
Repo: armbian/build PR: 8789
File: config/kernel/linux-sunxi64-edge.config:839-839
Timestamp: 2025-10-22T07:56:19.424Z
Learning: In Linux kernel configuration, some `=y` (builtin) options are infrastructure or feature flags that enable subsystems or features for modular drivers, rather than directly compiling code into the kernel. For example, in Armbian wireless configs, options like CONFIG_SPARD_WLAN_SUPPORT=y, CONFIG_SC23XX=y, CONFIG_WCN_BSP_DRIVER_BUILDIN=y, CONFIG_UNISOC_WIFI_PS=y are module infrastructure/feature enablers, while the actual drivers (CONFIG_WLAN_UWE5621=m, CONFIG_WLAN_UWE5622=m) remain as loadable modules. These infrastructure options don't cause kernel bloat.

Learnt from: EvilOlaf
Repo: armbian/build PR: 8619
File: config/sources/families/rockchip.conf:64-70
Timestamp: 2025-09-14T06:10:25.610Z
Learning: In the Armbian build system, rk32xx and rk33xx Rockchip SoCs no longer have BSP-based (vendor) kernel branches. The rk3506 is the first 32-bit Rockchip SoC to use the vendor branch in the current codebase.

Learnt from: EvilOlaf
Repo: armbian/build PR: 8886
File: patch/kernel/rk35xx-vendor-6.1/dt/rk3528-nanopi-rev01.dts:9-9
Timestamp: 2025-11-08T06:39:24.512Z
Learning: In Armbian's Rockchip vendor kernel branches (rk35xx-vendor), device tree files may not require the same headers as mainline Linux. For example, input key definitions like KEY_BACK and KEY_VOLUMEUP may be handled differently in BSP kernels and don't necessarily need explicit includes like <dt-bindings/input/input.h> that would be required in mainline kernel device trees.

Learnt from: igorpecovnik
Repo: armbian/build PR: 8812
File: config/kernel/linux-rockchip-edge.config:730-733
Timestamp: 2025-10-23T19:50:25.841Z
Learning: For ATH12K wireless driver configuration: only CONFIG_ATH12K=m needs to be explicitly set in kernel config files. The kernel build system automatically selects CONFIG_ATH12K_PCI when both CONFIG_ATH12K and CONFIG_PCI are enabled. This pattern is consistent across all Armbian edge kernel configs. CONFIG_ATH12K_PCI does not need to be explicitly added to config files.

Learnt from: tabrisnet
Repo: armbian/build PR: 8661
File: lib/functions/compilation/armbian-kernel.sh:194-201
Timestamp: 2025-09-22T21:52:01.225Z
Learning: The kernel_config_set_m function in lib/functions/compilation/armbian-kernel.sh preserves existing 'y' (built-in) settings and only sets options to 'm' (module) when they are not already built-in, achieving "prefer modules but allow built-ins" behavior.

Learnt from: tabrisnet
Repo: armbian/build PR: 8661
File: lib/functions/compilation/armbian-kernel.sh:194-201
Timestamp: 2025-09-22T21:52:01.225Z
Learning: The kernel_config_set_m function in lib/functions/compilation/armbian-kernel.sh preserves existing 'y' (built-in) settings and only sets options to 'm' (module) when they are not already built-in, achieving "prefer modules but allow built-ins" behavior.

📚 Learning: 2025-10-22T07:56:19.424Z

Learnt from: igorpecovnik
Repo: armbian/build PR: 8789
File: config/kernel/linux-sunxi64-edge.config:839-839
Timestamp: 2025-10-22T07:56:19.424Z
Learning: In Linux kernel configuration, some `=y` (builtin) options are infrastructure or feature flags that enable subsystems or features for modular drivers, rather than directly compiling code into the kernel. For example, in Armbian wireless configs, options like CONFIG_SPARD_WLAN_SUPPORT=y, CONFIG_SC23XX=y, CONFIG_WCN_BSP_DRIVER_BUILDIN=y, CONFIG_UNISOC_WIFI_PS=y are module infrastructure/feature enablers, while the actual drivers (CONFIG_WLAN_UWE5621=m, CONFIG_WLAN_UWE5622=m) remain as loadable modules. These infrastructure options don't cause kernel bloat.

Applied to files:

config/kernel/linux-rockchip-rv1106-vendor.config

📚 Learning: 2025-08-11T22:00:13.411Z

Learnt from: rafayahmed317
Repo: armbian/build PR: 8484
File: config/kernel/linux-rk35xx-vendor.config:904-906
Timestamp: 2025-08-11T22:00:13.411Z
Learning: In the linux-rk35xx-vendor kernel, the LTE driver options (CONFIG_LTE, CONFIG_LTE_RM310, CONFIG_LTE_EM05) are defined as boolean in drivers/net/lte/Kconfig and cannot be built as modules - they must be either built-in (=y) or disabled.

Applied to files:

config/kernel/linux-rockchip-rv1106-vendor.config

📚 Learning: 2025-08-30T04:13:16.457Z

Learnt from: tabrisnet
Repo: armbian/build PR: 0
File: :0-0
Timestamp: 2025-08-30T04:13:16.457Z
Learning: Armbian kernel configuration files like linux-filogic-current.config are autogenerated overlays on top of arch defconfig. Comments added manually will be lost during future updates by maintainers, and explicit "CONFIG_OPTION is not set" statements aren't needed for mutually exclusive options since these are overlay configs that only specify changes from the base configuration.

Applied to files:

config/kernel/linux-rockchip-rv1106-vendor.config

📚 Learning: 2025-09-22T21:52:01.225Z

Learnt from: tabrisnet
Repo: armbian/build PR: 8661
File: lib/functions/compilation/armbian-kernel.sh:194-201
Timestamp: 2025-09-22T21:52:01.225Z
Learning: The kernel_config_set_m function in lib/functions/compilation/armbian-kernel.sh preserves existing 'y' (built-in) settings and only sets options to 'm' (module) when they are not already built-in, achieving "prefer modules but allow built-ins" behavior.

Applied to files:

config/kernel/linux-rockchip-rv1106-vendor.config

📚 Learning: 2025-11-02T20:49:56.719Z

Learnt from: igorpecovnik
Repo: armbian/build PR: 8849
File: config/boards/radxa-e54c.csc:14-28
Timestamp: 2025-11-02T20:49:56.719Z
Learning: In Armbian board configuration files (config/boards/*.conf, *.csc, etc.), do not use kernel_config_set, kernel_config_set_m, kernel_config_set_y, or custom_kernel_config__* functions to modify kernel configuration. Kernel configuration is associated with LINUXFAMILY/BOARDFAMILY, not individual BOARD. Board-specific kernel modifications cause inconsistency in kernel packages published to the apt repository because boards within a family share the same kernel packages. Kernel configuration changes must be made in the appropriate kernel config file (e.g., config/kernel/linux-*-*.config) or in family configuration files (config/sources/families/*.conf, *.inc) instead.

Applied to files:

config/kernel/linux-rockchip-rv1106-vendor.config

📚 Learning: 2025-10-22T07:51:53.015Z

Learnt from: igorpecovnik
Repo: armbian/build PR: 8789
File: config/kernel/linux-sunxi64-edge.config:839-839
Timestamp: 2025-10-22T07:51:53.015Z
Learning: In Armbian's wireless driver configuration, CONFIG_RK_WIFI_DEVICE_* options are Rockchip-specific device registration settings, while CONFIG_WLAN_UWE* are the actual cross-platform driver modules for UWE5622 wireless chips. The UWE5622 chip (manufactured by Unisoc/Spreadtrum) is used on multiple Allwinner boards including Orange Pi Zero 2/2W/3 and Orange Pi 3 LTS, so CONFIG_WLAN_UWE5621/5622 along with Unisoc infrastructure options (CONFIG_SPARD_WLAN_SUPPORT, CONFIG_SC23XX, CONFIG_UNISOC_WIFI_PS, CONFIG_WCN_BSP_DRIVER_BUILDIN) are correct in sunxi64 kernel configs.

Applied to files:

config/kernel/linux-rockchip-rv1106-vendor.config

📚 Learning: 2025-10-23T19:48:42.980Z

Learnt from: igorpecovnik
Repo: armbian/build PR: 8812
File: config/kernel/linux-sm8250-edge.config:498-501
Timestamp: 2025-10-23T19:48:42.980Z
Learning: For Armbian EDGE kernel configs, CONFIG_ATH12K=m alone is sufficient for PCI-based Wi-Fi 7 devices (e.g., WCN785x/QCN9274). A separate CONFIG_ATH12K_PCI option is not required, as confirmed by maintainer testing.

Applied to files:

config/kernel/linux-rockchip-rv1106-vendor.config

📚 Learning: 2025-09-22T21:52:01.225Z

Learnt from: tabrisnet
Repo: armbian/build PR: 8661
File: lib/functions/compilation/armbian-kernel.sh:194-201
Timestamp: 2025-09-22T21:52:01.225Z
Learning: In lib/functions/compilation/armbian-kernel.sh, the kernel_config_modifying_hashes array is not universally required for all kernel configuration functions - some functions like armbian_kernel_config__netkit() operate without it, and adding entries with '=m' would be incorrect when the actual result might be '=y' for options already built-in.

Applied to files:

config/kernel/linux-rockchip-rv1106-vendor.config

📚 Learning: 2025-07-17T04:16:29.551Z

Learnt from: pyavitz
Repo: armbian/build PR: 8388
File: config/boards/kickpik2b.conf:56-72
Timestamp: 2025-07-17T04:16:29.551Z
Learning: For AIC8800 Bluetooth devices in Armbian board configurations, systemd service configurations intentionally use Type=idle and boot delays because there is no compatibility to load AIC8800 bluetooth in mainline kernel. These delays and service timing are necessary workarounds for hardware limitations rather than performance issues.

Applied to files:

config/kernel/linux-rockchip-rv1106-vendor.config

📚 Learning: 2025-08-30T06:56:33.372Z

Learnt from: tabrisnet
Repo: armbian/build PR: 0
File: :0-0
Timestamp: 2025-08-30T06:56:33.372Z
Learning: In Armbian kernel configuration, the BTRFS configuration logic preserves existing settings (whether built-in 'y' or module 'm') and only sets BTRFS_FS to module when it was previously disabled or not set, achieving "allow but not require" flexibility while maintaining backward compatibility.

Applied to files:

config/kernel/linux-rockchip-rv1106-vendor.config

📚 Learning: 2025-10-23T19:50:25.841Z

Learnt from: igorpecovnik
Repo: armbian/build PR: 8812
File: config/kernel/linux-rockchip-edge.config:730-733
Timestamp: 2025-10-23T19:50:25.841Z
Learning: For ATH12K wireless driver configuration: only CONFIG_ATH12K=m needs to be explicitly set in kernel config files. The kernel build system automatically selects CONFIG_ATH12K_PCI when both CONFIG_ATH12K and CONFIG_PCI are enabled. This pattern is consistent across all Armbian edge kernel configs. CONFIG_ATH12K_PCI does not need to be explicitly added to config files.

Applied to files:

config/kernel/linux-rockchip-rv1106-vendor.config

📚 Learning: 2025-07-27T15:54:35.119Z

Learnt from: pyavitz
Repo: armbian/build PR: 8421
File: config/kernel/linux-sunxi64-edge.config:2168-2173
Timestamp: 2025-07-27T15:54:35.119Z
Learning: In the Armbian build system, staging 802.11 drivers like CONFIG_RTLLIB, CONFIG_RTL8192E, CONFIG_R8712U are kept enabled alongside upstream rtw88 drivers because rtw88 is still under development and suffers from reliability issues. The staging drivers serve as necessary fallbacks when upstream drivers are unstable, prioritizing working hardware over avoiding technical conflicts.

Applied to files:

config/kernel/linux-rockchip-rv1106-vendor.config

📚 Learning: 2025-10-11T19:52:54.648Z

Learnt from: tabrisnet
Repo: armbian/build PR: 8746
File: config/kernel/linux-filogic-edge.config:344-470
Timestamp: 2025-10-11T19:52:54.648Z
Learning: The chainsx/linux-filogic kernel (legacy branch) for BPI-R4 uses out-of-tree proprietary drivers (CONFIG_NET_DSA_AN8855, CONFIG_AIROHA_EN8801SC_PHY, CONFIG_AIR_AN8855_PHY, CONFIG_MDIO_AN8855, CONFIG_MFD_AIROHA_AN8855). The frank-w/BPI-Router-Linux kernel (current and edge branches) uses mainline kernel drivers instead: CONFIG_NET_DSA_MT7530 for the DSA switch and CONFIG_MEDIATEK_2P5GE_PHY for PHY support. These provide equivalent functionality for BPI-R4 networking.

Applied to files:

config/kernel/linux-rockchip-rv1106-vendor.config

📚 Learning: 2025-10-26T12:56:29.185Z

Learnt from: rpardini
Repo: armbian/build PR: 8820
File: config/sources/families/include/meson64_common.inc:51-53
Timestamp: 2025-10-26T12:56:29.185Z
Learning: In the Armbian build framework, scripts/config correctly handles kernel configuration option names both with and without the CONFIG_ prefix, so opts_m+=("CONFIG_RTL8822CS") and opts_m+=("RTL8822CS") are both valid and will work correctly.

Applied to files:

config/kernel/linux-rockchip-rv1106-vendor.config

🔇 Additional comments (2)

config/kernel/linux-rockchip-rv1106-vendor.config (2)

82-102: Bluetooth configuration corrections are accurate.

These BT_* options (BT_RFCOMM_TTY, BT_BNEP_MC_FILTER, BT_BNEP_PROTO_FILTER, etc.) are defined as bool type in the kernel Kconfig, which means they cannot be set to =m (module)—only =y (enabled) or disabled. The changes from =m to =y correctly resolve the olddefconfig warnings. Reference implementations (e.g., Ubuntu Core) confirm this pattern: parent tristate options like CONFIG_BT_RFCOMM can be =m, but their boolean sub-options like CONFIG_BT_RFCOMM_TTY must be =y.

244-244: WLAN boolean option corrected appropriately.

CONFIG_AIC_WLAN_SUPPORT is corrected from =m to =y, consistent with the Bluetooth fixes—this is also a boolean option that cannot be modular.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

vidplace7

Tested. Working well 👍
Thanks for cleaning this up @rpardini ❤️

github-actions · 2025-11-09T18:22:42Z

✅ This PR has been reviewed and approved — all set for merge!

rpardini added 2 commits November 9, 2025 14:05

github-actions bot added 11 Milestone: Fourth quarter release size/small PR with less then 50 lines labels Nov 9, 2025

github-actions bot added Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... labels Nov 9, 2025

rpardini marked this pull request as ready for review November 9, 2025 13:24

rpardini requested a review from vidplace7 as a code owner November 9, 2025 13:24

rpardini mentioned this pull request Nov 9, 2025

Implement option to skip certain kernel configs that don't want to play along #8896

Merged

2 tasks

vidplace7 approved these changes Nov 9, 2025

View reviewed changes

github-actions bot added the Ready to merge Reviewed, tested and ready for merge label Nov 9, 2025

github-actions bot removed the Needs review Seeking for review label Nov 9, 2025

igorpecovnik merged commit 7734c00 into armbian:main Nov 9, 2025
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

rockchip-rv1106: .config: manual fixes #8898

rockchip-rv1106: .config: manual fixes #8898

Uh oh!

rpardini commented Nov 9, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Nov 9, 2025 •

edited

Loading

Uh oh!

vidplace7 left a comment

Uh oh!

github-actions bot commented Nov 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Uh oh!

rockchip-rv1106: .config: manual fixes #8898

rockchip-rv1106: .config: manual fixes #8898

Uh oh!

Conversation

rpardini commented Nov 9, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

rockchip-rv1106: .config: manual fixes

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Nov 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

vidplace7 left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

rpardini commented Nov 9, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Nov 9, 2025 •

edited

Loading