-
Notifications
You must be signed in to change notification settings - Fork 6.7k
docs: vscode settings recommendation is outdated #25925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
nitishfy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM! Can you please fix the failing checks?
Signed-off-by: alexrecuenco <[email protected]>
7fe11f3 to
e0d0cd5
Compare
Thanks! All fixed now. Apologies for any inconvenience |
| "!cwd": false | ||
| } | ||
| ], | ||
| "eslint.experimental.useFlatConfig": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint
The experimental settings eslint.experimental.useFlatConfig is deprecated and should only be used for ESLint versions >= 8.21 < 8.57.0.
I checked the release note and lgtm
rumstead
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks!
The extension recommendation is outdated.
See extensions 3.0.5 release notes
https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint