Skip to content

Conversation

@alexrecuenco
Copy link
Contributor

The extension recommendation is outdated.

See extensions 3.0.5 release notes

https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint

@alexrecuenco alexrecuenco requested a review from a team as a code owner January 10, 2026 19:49
@bunnyshell
Copy link

bunnyshell bot commented Jan 10, 2026

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

Copy link
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM! Can you please fix the failing checks?

@alexrecuenco alexrecuenco changed the title Docs(small): vscode settings recommendation is outdated docs(small): vscode settings recommendation is outdated Jan 13, 2026
@alexrecuenco alexrecuenco changed the title docs(small): vscode settings recommendation is outdated docs: vscode settings recommendation is outdated Jan 13, 2026
@alexrecuenco
Copy link
Contributor Author

alexrecuenco commented Jan 13, 2026

Overall LGTM! Can you please fix the failing checks?

Thanks! All fixed now. Apologies for any inconvenience

"!cwd": false
}
],
"eslint.experimental.useFlatConfig": true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint

The experimental settings eslint.experimental.useFlatConfig is deprecated and should only be used for ESLint versions >= 8.21 < 8.57.0.

I checked the release note and lgtm

Copy link
Member

@rumstead rumstead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks!

@rumstead rumstead merged commit 6a3a540 into argoproj:master Jan 13, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants