fix: helm parameters show effective values from inline values

[nijdarshan]

Summary

Fixes #9213

PARAMETERS section in UI showed chart defaults instead of actual values when using inline helm.values. Now merges user's inline values and parameter overrides into displayed parameters.

Changes

• Added flattenValues() helper to convert nested YAML to dot-notation
• Modified populateHelmAppDetails() to merge inline values and parameters into the params map before display

Test plan

• Local lint passes
• Unit tests pass
• Manual test: created app with values: replicaCount: 10 - PARAMETERS now shows replicaCount: 10 instead of chart default 1

Signed-off-by: Darshan Nij [email protected]

[bunnyshell]

❗ Preview Environment deployment failed on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

• 🚀 /bns:deploy to redeploy the environment
• ❌ /bns:delete to remove the environment

[nijdarshan]

Current version:

---

Fixed:

[Mangaal]

Can we add a warning/log message when spec.source.helm.values is not a valid Helm values object?

[nijdarshan]

Added warning log when helm values parsing fails - will now log failed to parse helm values: <error> if the inline values YAML is malformed.

[Mangaal]

I have verified the changes locally and it is working as expected.
Could you please add some tests to cover this new logic? I have also left a small suggestion, please feel free to resolve it.

[nijdarshan]

I have verified the changes locally and it is working as expected. Could you please add some tests to cover this new logic? I have also left a small suggestion, please feel free to resolve it.

Added 3 unit tests:

• TestFlattenValues - tests the helper function with simple, nested, deeply nested, array values, and empty map cases
• Test_populateHelmAppDetails_WithInlineValues - verifies inline values are merged into parameters
• Test_populateHelmAppDetails_WithParameterOverrides - verifies --set parameters override inline values (precedence)

[ppapapetrou76]

The code unmarshals inline values into a map[string]any then calls flattenValues(userVals, params, "")
If the YAML is not a map at the document root (e.g., a top-level array), unmarshalling into map[string]any will yield nil (no error), and flattenValues will be called with nil, which will panic.

Also nested maps may sometimes have non-string key types (map[interface{}]interface{}) depending on the yaml parsing library

I recommend using the any type and change the code to something like this

Suggested change

	if q.Source.Helm != nil && !q.Source.Helm.ValuesIsEmpty() {
	var userVals map[string]any
	if err := yaml.Unmarshal(q.Source.Helm.ValuesYAML(), &userVals); err != nil {
	log.Warnf("failed to parse helm values: %v", err)
	} else {
	flattenValues(userVals, params, "")
	}
	}
	if q.Source.Helm != nil && !q.Source.Helm.ValuesIsEmpty() {
	var raw any
	if err := yaml.Unmarshal(q.Source.Helm.ValuesYAML(), &raw); err != nil {
	log.Warnf("failed to parse helm values: %v", err)
	} else {
	// flatten supports arbitrary root types and map[interface{}] keys
	flattenAnyValues(raw, params, "")
	}
	}

[nijdarshan]

aaah, you are right! lemme fix this.

[nijdarshan]

Fixed in latest commit. Now using any type with type assertion:

var raw any
if err := yaml.Unmarshal(..., &raw); err != nil {
    log.Warnf("failed to parse helm values: %v", err)
} else if userVals, ok := raw.(map[string]any); ok {
    flattenValues(userVals, params, "")
} else if raw != nil {
    log.Warnf("helm values is not a map, got %T", raw)
}

Added edge case tests in Test_populateHelmAppDetails_WithInvalidValues:

• top-level array should not panic
• scalar value should not panic
• malformed yaml should not panic