fix: Subscription health check when installplanapproval is set to manual #25923
+222
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tallplanapproval is set to manual We first check if the subscription has installPlanApproval set to Manual, then if in the conditions we see that there is an InstallPlanPending condition with reason RequiresApproval but no installedCSV we set isManualApprovalPending to true. Then when this isManualApprovalPending is set to true we consider the subscription to be healthy. Tested with the subscription described in the GH issue and it fixes the problem. Also verified that the subscription object stays in "Progressing" state until the it was manually approved. Fixes: argoproj#25921 Signed-off-by: Michele Baldessari <[email protected]>
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We first check if the subscription has installPlanApproval set to Manual, then if in the conditions we see that there is an InstallPlanPending condition with reason RequiresApproval but no installedCSV we set isManualApprovalPending to true.
Then when this isManualApprovalPending is set to true we consider the subscription to be healthy.
Tested with the subscription described in the GH issue and it fixes the problem. Also verified that the subscription object stays in "Progressing" state until the it was manually approved.
Fixes: #25921
Checklist: