fix: error sending generate manifest metadata cmp server #25891
+65
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patroklos Papapetrou <[email protected]>
Signed-off-by: Patroklos Papapetrou <[email protected]>
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
reggie-k
approved these changes
Jan 8, 2026
choejwoo
reviewed
Jan 13, 2026
Comment on lines
-115
to
+119
| conn, cmpClient, connFound = cmpSupports(ctx, pluginSockFilePath, appPath, repoPath, file.Name(), env, tarExcludedGlobs, false) | ||
| conn, cmpClient, connFound, lastErr = cmpSupports(ctx, pluginSockFilePath, appPath, repoPath, file.Name(), env, tarExcludedGlobs, false) |
Member
There was a problem hiding this comment.
I might be misunderstanding the intent here, so I just want to make sure I understand correctly.
In discovery mode, iterate over multiple socket files. If the first probe returns an error like EOF, but a later probe returns connfound=false, lastErr=nil (not supported), does that later result overwrite lastErr and effectively drop the earlier error?
Member
There was a problem hiding this comment.
@choejwoo yes that is correct
Thanks for confirming, LGTM.
choejwoo
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25511
This PR has a two-level fix
The first commit addresses the actual issue as described below
reposerver tries to detect the CMP sidecar (
DetectConfigManagementPlugin). If the detection fails, it returns: "could not find cmp-server plugin with name %q supporting the given repository". That is exactly the message in the user's logs.If detect succeeds, reposerver opens a GenerateManifest stream:
generateManifestStream, err := cmpClient.GenerateManifest(ctx, grpc_retry.Disable())It then calls
SendRepoStreamto send metadata, but the code currently passes thisgenerateManifestStream.Context()as context. If this context is by any reason cancelled/closed early on the server-side (for any reason) the client-side will return an error (sometimes io.EOF), which is wrapped and logged as: "error sending generate manifest metadata to cmp-server: EOF". The PR now uses the original context.The second commit improves the diagnostic/debugging level of
DetectConfigManagementPluginfunction as belowCurrently,
DetectConfigManagementPluginreturns a generic error when a named plugin is not found/usable: "could not find cmp-server plugin with name %q supporting the given repository".cmpSupportsfunction logs detailed reasons but does not return the concrete error to the caller.Checklist: