Skip to content

[SPARK-49246][SQL][TESTS][FOLLOWUP] Fix flaky CollationSuite #48031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
panbingkun wants to merge 2 commits into from
Closed

[SPARK-49246][SQL][TESTS][FOLLOWUP] Fix flaky CollationSuite #48031

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
477d147
[SPARK-49246][TESTS] Fix CollationSuite
panbingkun Sep 9, 2024
3ae56c0
update
panbingkun Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -947,7 +947,10 @@ class CollationSuite extends DatasourceV2SQLBase with AdaptiveSparkPlanHelper {
withTable(table) {
sql(s"create table $table (a array<string collate utf8_lcase>) using parquet")
sql(s"insert into $table values (array('aaa')), (array('AAA'))")
checkAnswer(sql(s"select distinct a from $table"), Seq(Row(Seq("aaa"))))
val result = sql(s"select distinct a from $table").collect()
assert(result.length === 1)
val data = result.head.get(0).asInstanceOf[scala.collection.mutable.ArraySeq[String]]
Copy link
Contributor

@LuciferYang LuciferYang Sep 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
val data = result.head.get(0).asInstanceOf[scala.collection.mutable.ArraySeq[String]]
val data = result.head.getSeq[String](0)

Copy link
Contributor Author

@panbingkun panbingkun Sep 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, thanks!

assert(data === Array("aaa") || data === Array("AAA"))
Copy link
Contributor

@cloud-fan cloud-fan Sep 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so the test becomes flaky? Reading the test query I think both aaa and AAA are correct result. cc @stefankandic

Copy link
Contributor Author

@panbingkun panbingkun Sep 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it becomes flaky. The returned value is not non-deterministic.

Copy link
Member

@MaxGekk MaxGekk Sep 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean just non-deterministic, I guess.

}
// map doesn't support aggregation
withTable(table) {
Expand All @@ -968,7 +971,10 @@ class CollationSuite extends DatasourceV2SQLBase with AdaptiveSparkPlanHelper {
withTable(table) {
sql(s"create table $table (s struct<fld:string collate utf8_lcase>) using parquet")
sql(s"insert into $table values (named_struct('fld', 'aaa')), (named_struct('fld', 'AAA'))")
checkAnswer(sql(s"select s.fld from $table group by s"), Seq(Row("aaa")))
val result = sql(s"select s.fld from $table group by s").collect()
assert(result.length === 1)
val data = result.head.getString(0)
assert(data === "aaa" || data === "AAA")
}
}

Expand Down